Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 887993003: Remove unused globalRef/globalUnref. (Closed)

Created:
5 years, 10 months ago by scroggo
Modified:
5 years, 10 months ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M include/core/SkPixelRef.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/core/SkPixelRef.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
scroggo
Unless you think we'll need to add them back?
5 years, 10 months ago (2015-01-30 15:13:52 UTC) #2
djsollen
lgtm, if we need to add them back we will.
5 years, 10 months ago (2015-01-30 15:22:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887993003/1
5 years, 10 months ago (2015-01-30 15:29:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/1872ad0fe97d8e90446ee619b273de87e9b8c1fa
5 years, 10 months ago (2015-01-30 15:34:51 UTC) #6
reed1
5 years, 10 months ago (2015-01-30 15:51:52 UTC) #8
Message was sent while issue was closed. 
awesome

Powered by Google App Engine
This is Rietveld 408576698