Remove visit and override visitExpression instead to make sure we check that the code produced for …

pkg/compiler/lib/src/js_backend/codegen/codegen.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_generator;
 
 import 'glue.dart';
 
 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
 import '../../js/js.dart' as js;
@@ skipping 65 matching lines @@
     }
 
     if (jsVariables.length > 0) {
       // Would be nice to avoid inserting at the beginning of list.
       accumulator.insert(0, new js.ExpressionStatement(
           new js.VariableDeclarationList(jsVariables)));
     }
     return new js.Fun(parameters, new js.Block(accumulator));
   }
 
-  js.Expression visit(tree_ir.Expression node) {
+  @override
+  js.Expression visitExpression(tree_ir.Expression node) {
     js.Expression result = node.accept(this);
     if (result == null) {
       glue.reportInternalError('$node did not produce code.');
     }
     return result;
   }
 
   /// Generates a name for the given variable. First trying with the name of
   /// the [Variable.element] if it is non-null.
   String getVariableName(tree_ir.Variable variable) {
@@ skipping 37 matching lines @@
 
   @override
   js.Expression visitConcatenateStrings(tree_ir.ConcatenateStrings node) {
     return giveup(node);
     // TODO: implement visitConcatenateStrings
   }
 
   @override
   js.Expression visitConditional(tree_ir.Conditional node) {
     return new js.Conditional(
-        visit(node.condition),
-        visit(node.thenExpression),
-        visit(node.elseExpression));
+        visitExpression(node.condition),
+        visitExpression(node.thenExpression),
+        visitExpression(node.elseExpression));
   }
 
   js.Expression buildConstant(ConstantValue constant) {
     registry.registerCompileTimeConstant(constant);
     return glue.constantReference(constant);
   }
 
   @override
   js.Expression visitConstant(tree_ir.Constant node) {
     return buildConstant(node.expression.value);
@@ skipping 121 matching lines @@
     List<js.Expression> args =
         <js.Expression>[new js.ArrayInitializer(entries)];
     return buildStaticInvoke(
         new Selector.call(constructor.name, constructor.library, 2),
         constructor,
         args);
   }
 
   @override
   js.Expression visitLogicalOperator(tree_ir.LogicalOperator node) {
-    return new js.Binary(node.operator, visit(node.left), visit(node.right));
+    return new js.Binary(
+        node.operator,
+        visitExpression(node.left),
+        visitExpression(node.right));
   }
 
   @override
   js.Expression visitNot(tree_ir.Not node) {
     return new js.Prefix("!", visitExpression(node.operand));
   }
 
   @override
   js.Expression visitReifyTypeVar(tree_ir.ReifyTypeVar node) {
     return giveup(node);
@@ skipping 183 matching lines @@
   void visitSetField(tree_ir.SetField node) {
     js.PropertyAccess field =
         new js.PropertyAccess.field(
             visitExpression(node.object),
             glue.instanceFieldPropertyName(node.field));
     js.Assignment asn = new js.Assignment(field, visitExpression(node.value));
     accumulator.add(new js.ExpressionStatement(asn));
     visitStatement(node.next);
   }
 }