Chromium Code Reviews
Help | Chromium Project | Sign in
(739)

Issue 8879040: Fix failure to disable cloud print connector. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by Albert Bodenhamer
Modified:
2 years, 4 months ago
Reviewers:
gene
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Fix failure to disable cloud print connector.
Fix issue where a crash in the cloud print connector on shutdown will prevent the enable pref change from being persisted.
Moves the write of the pref to earlier in the shutdown process so that if a crash occurs the pref will still be recorded.

BUG=106919
TEST=Verify 106919


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Lint Patch
M chrome/service/cloud_print/cloud_print_proxy.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
Commit:

Messages

Total messages: 6
Albert Bodenhamer
2 years, 4 months ago #1
gene
lgtm
2 years, 4 months ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/8879040/1
2 years, 4 months ago #3
I haz the power (commit-bot)
Try job failure for 8879040-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
2 years, 4 months ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/8879040/1
2 years, 4 months ago #5
I haz the power (commit-bot)
2 years, 4 months ago #6
Change committed as 113852
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6