chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 8879022: retry 113568 - extensions: remove install/uninstall terminology

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 8879022: retry 113568 - extensions: remove install/uninstall terminology (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm ('k') | chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index f20ae1ad8b9f2f03199874e2243ec7313f3493c3..cc4088d432d0e49e77a65abc4bbb85216a460daf 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -23,6 +23,7 @@

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_registrar.h"

#include "content/public/browser/notification_source.h"

+#include "grit/chromium_strings.h"

#include "grit/generated_resources.h"

#import "skia/ext/skia_utils_mac.h"

#import "third_party/GTM/AppKit/GTMUILocalizerAndLayoutTweaker.h"

@@ -304,7 +305,8 @@ class ExtensionLoadedNotificationObserver

string16 extension_name = UTF8ToUTF16(extension_->name().c_str());

base::i18n::AdjustStringForLocaleDirection(&extension_name);

[extensionInstalledMsg_ setStringValue:l10n_util::GetNSStringF(

- IDS_EXTENSION_INSTALLED_HEADING, extension_name)];

+ IDS_EXTENSION_INSTALLED_HEADING, extension_name,

+ l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME))];

[GTMUILocalizerAndLayoutTweaker

sizeToFitFixedWidthTextField:extensionInstalledMsg_];

newWindowHeight += [extensionInstalledMsg_ frame].size.height +