Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 887883002: WTF should get time from base directly (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
ojan
CC:
ojan, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

WTF should get time from base directly There's no reason to bounce through several indirections to get the current time. We can just call into base directly now. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c4cd94f0cdefdff696ff210c618d8ebed34fbf4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -57 lines) Patch
M sky/engine/platform/testing/RunAllTests.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M sky/engine/web/Sky.cpp View 2 chunks +1 line, -11 lines 0 comments Download
M sky/engine/wtf/CurrentTime.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/wtf/CurrentTime.cpp View 1 chunk +4 lines, -15 lines 0 comments Download
M sky/engine/wtf/WTF.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/WTF.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/wtf/testing/RunAllTests.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M sky/viewer/platform/platform_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/viewer/platform/platform_impl.cc View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-01-30 05:06:41 UTC) #1
ojan
lgtm
5 years, 10 months ago (2015-01-30 05:44:14 UTC) #2
abarth-chromium
5 years, 10 months ago (2015-01-30 06:08:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4cd94f0cdefdff696ff210c618d8ebed34fbf4f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698