Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 887873003: media: Add DefaultMediaPermission. (Closed)

Created:
5 years, 10 months ago by xhwang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, eme-reviews_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org, viettrungluu+watch_chromium.org, Aaron Boodman, ddorwin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Add DefaultMediaPermission. Also pass MediaPermission to ProxyDecryptor, in preparation for triggering user prompt from ProxyDecryptor for prefixed EME implementation. TBR=jam@chromium.org,aa@chromium.org BUG=446263 Committed: https://crrev.com/60b430a11d662a93795cef0fd137cb7018172ab9 Cr-Commit-Position: refs/heads/master@{#314082}

Patch Set 1 #

Patch Set 2 : fix android build #

Patch Set 3 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -14 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 3 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 5 chunks +12 lines, -4 lines 0 comments Download
M media/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M media/blink/encrypted_media_player_support.h View 3 chunks +4 lines, -0 lines 0 comments Download
M media/blink/encrypted_media_player_support.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M media/blink/webencryptedmediaclient_impl.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/webmediaplayer_params.h View 4 chunks +9 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_params.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/cdm/proxy_decryptor.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/cdm/proxy_decryptor.cc View 3 chunks +4 lines, -1 line 0 comments Download
A media/filters/default_media_permission.h View 1 chunk +39 lines, -0 lines 0 comments Download
A media/filters/default_media_permission.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/html_document.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/html_document.cc View 1 2 3 chunks +10 lines, -5 lines 0 comments Download
M mojo/services/html_viewer/webmediaplayer_factory.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/webmediaplayer_factory.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
xhwang
sandersd: PTAL ddorwin: FYI
5 years, 10 months ago (2015-01-30 17:53:39 UTC) #3
sandersd (OOO until July 31)
lgtm
5 years, 10 months ago (2015-01-30 22:16:07 UTC) #4
xhwang
TBRing jam@ for content/ and aa@ for html_viewer/ changes since this change is trivial. Let ...
5 years, 10 months ago (2015-01-30 22:29:52 UTC) #6
xhwang
rebase only
5 years, 10 months ago (2015-01-30 23:04:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887873003/60001
5 years, 10 months ago (2015-02-01 04:36:57 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 10 months ago (2015-02-01 05:21:17 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-01 05:22:17 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/60b430a11d662a93795cef0fd137cb7018172ab9
Cr-Commit-Position: refs/heads/master@{#314082}

Powered by Google App Engine
This is Rietveld 408576698