Issue 887873002: Subzero: Minor Makefile fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 887873002: Subzero: Minor Makefile fix. (Closed)

Created:
5 years, 10 months ago by Jim Stichnoth

Modified:
5 years, 10 months ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Minor Makefile fix. The problem showed up after the link step failed, in which case $(OBJDIR)/llvm2ice was deleted but the ./llvm2ice symlink still existed. A subsequent "make check-lit" or "make check" would fail, so the basic "make" would have to be done first. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=51d00936f83176c124405ce8373c85a99debf08b

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Makefile.standalone	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

jvoung (off chromium)

Ah, I think have run into that but never figured it out LGTM

5 years, 10 months ago (2015-01-30 16:40:39 UTC) #3

Jim Stichnoth

5 years, 10 months ago (2015-01-30 17:34:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
51d00936f83176c124405ce8373c85a99debf08b (presubmit successful).