Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 887853002: Shutdown the It2Me host cleanly. (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@it2me_host_dcheck
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shutdown the It2Me host cleanly. Previously It2Me host was shutting down before letting all shutdown tasks finish, which would often cause crashes. Now NativeMessagingPipe is responsible for host and channel deletion and the task runner for the main thread doesn't stop until the host is destroyed. BUG=453016 Committed: https://crrev.com/1a7589308f5cda5f58fa70a515962add2a33f7a3 Cr-Commit-Position: refs/heads/master@{#313967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -35 lines) Patch
M remoting/host/it2me/it2me_native_messaging_host_main.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_unittest.cc View 3 chunks +5 lines, -17 lines 0 comments Download
M remoting/host/native_messaging/native_messaging_pipe.h View 2 chunks +1 line, -3 lines 0 comments Download
M remoting/host/native_messaging/native_messaging_pipe.cc View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sergey Ulanov
5 years, 10 months ago (2015-01-30 01:50:50 UTC) #2
kelvinp
lgtm
5 years, 10 months ago (2015-01-30 19:01:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887853002/1
5 years, 10 months ago (2015-01-30 19:26:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 20:02:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 20:04:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a7589308f5cda5f58fa70a515962add2a33f7a3
Cr-Commit-Position: refs/heads/master@{#313967}

Powered by Google App Engine
This is Rietveld 408576698