Removed ScopedAllowIO from MetricsStateManager.

Removed ScopedAllowIO from MetricsStateManager.

BUG=413783
Committed: https://crrev.com/c4f022a6bd3426307459d3773a0b86553d3efeea
Cr-Commit-Position: refs/heads/master@{#315371}

[gayane -on leave until 09-2017, 2015-02-09 16:44:11]

gayane@chromium.org changed reviewers:
+ asvitkine@chromium.org

[gayane -on leave until 09-2017, 2015-02-09 16:44:12]

Please have a look

[Alexei Svitkine (slow), 2015-02-09 16:48:06]

https://codereview.chromium.org/887843003/diff/1/chrome/browser/metrics/metri...
File chrome/browser/metrics/metrics_services_manager.cc (right):

https://codereview.chromium.org/887843003/diff/1/chrome/browser/metrics/metri...
chrome/browser/metrics/metrics_services_manager.cc:28: // Posts
StoreMetricsClientInfo on IO thread.
IO thread doesn't play into this. The current code posts to FILE thread.

I would actually expand the comment to mention _why_ it posts it to another
thread. i.e. because GoogleUpdateSettings::StoreMetricsClientInfo does IO, so it
can't be done on UI thread.

https://codereview.chromium.org/887843003/diff/1/chrome/browser/metrics/metri...
chrome/browser/metrics/metrics_services_manager.cc:31:
content::BrowserThread::FILE, FROM_HERE,
It's better to use the worker pool for this.

i.e. do content::BrowserThread::GetBlockingPool()->PostTask()

[gayane -on leave until 09-2017, 2015-02-09 19:09:24]

changed to blocking pool

https://codereview.chromium.org/887843003/diff/1/chrome/browser/metrics/metri...
File chrome/browser/metrics/metrics_services_manager.cc (right):

https://codereview.chromium.org/887843003/diff/1/chrome/browser/metrics/metri...
chrome/browser/metrics/metrics_services_manager.cc:28: // Posts
StoreMetricsClientInfo on IO thread.
On 2015/02/09 16:48:05, Alexei Svitkine wrote:
> IO thread doesn't play into this. The current code posts to FILE thread.
> 
> I would actually expand the comment to mention _why_ it posts it to another
> thread. i.e. because GoogleUpdateSettings::StoreMetricsClientInfo does IO, so
it
> can't be done on UI thread.

Done.

https://codereview.chromium.org/887843003/diff/1/chrome/browser/metrics/metri...
chrome/browser/metrics/metrics_services_manager.cc:31:
content::BrowserThread::FILE, FROM_HERE,
On 2015/02/09 16:48:05, Alexei Svitkine wrote:
> It's better to use the worker pool for this.
> 
> i.e. do content::BrowserThread::GetBlockingPool()->PostTask()

Done.

[Alexei Svitkine (slow), 2015-02-09 19:16:53]

lgtm

[gayane -on leave until 09-2017, 2015-02-09 19:17:22]

The CQ bit was checked by gayane@chromium.org

[commit-bot: I haz the power, 2015-02-09 19:18:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/887843003/20001

[commit-bot: I haz the power, 2015-02-09 20:17:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-09 20:18:16]

Patchset 2 (id:??) landed as
https://crrev.com/c4f022a6bd3426307459d3773a0b86553d3efeea
Cr-Commit-Position: refs/heads/master@{#315371}