Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 887843002: Implement new syntax for ImportDeclarations (Closed)

Created:
5 years, 10 months ago by adamk
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implemented new syntax for ImportDeclarations Also had to split ParseImportsList and ParseExportClause into separate methods as they have different rules about reserved words and arguments/eval. Added lots more test cases, including some export cases that were missed before due to incorrect checking of reserved words. BUG=v8:1569 LOG=n Committed: https://crrev.com/0c928d533a3418d982a97fdaa45f6e55e34ae039 Cr-Commit-Position: refs/heads/master@{#26338}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add more negative tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -30 lines) Patch
M src/parser.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/parser.cc View 1 3 chunks +142 lines, -25 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 3 chunks +69 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
adamk
5 years, 10 months ago (2015-01-30 01:16:32 UTC) #2
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/887843002/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/887843002/diff/1/test/cctest/test-parsing.cc#newcode4823 test/cctest/test-parsing.cc:4823: Maybe add? import {x}, def from 'm.js'; import ...
5 years, 10 months ago (2015-01-30 02:34:45 UTC) #3
adamk
https://codereview.chromium.org/887843002/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/887843002/diff/1/test/cctest/test-parsing.cc#newcode4823 test/cctest/test-parsing.cc:4823: On 2015/01/30 02:34:45, arv wrote: > Maybe add? > ...
5 years, 10 months ago (2015-01-30 03:04:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887843002/20001
5 years, 10 months ago (2015-01-30 03:05:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 03:26:57 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 03:27:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c928d533a3418d982a97fdaa45f6e55e34ae039
Cr-Commit-Position: refs/heads/master@{#26338}

Powered by Google App Engine
This is Rietveld 408576698