Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: runtime/lib/print_patch.dart

Issue 88783002: Isolate.spawn{Uri} only reports errors asynchronously. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 typedef void _PrintClosure(Object obj); 5 typedef void _PrintClosure(Object obj);
6 6
7 patch void printToConsole(String line) { 7 patch void printToConsole(String line) {
8 _printClosure(line); 8 _printClosure(line);
Ivan Posva 2013/12/12 12:11:49 Types mismatch between parameter and print closure
floitsch 2013/12/12 21:08:37 Updated the typedef.
9 } 9 }
10 10
11 void _unsupportedPrint(Object obj) { 11 void _unsupportedPrint(String line) {
Ivan Posva 2013/12/12 12:11:49 This does not match the _PrintClosure type. This
floitsch 2013/12/12 21:08:37 Added comment. It is supposed to get a string.
12 throw new UnsupportedError("'print' is not supported"); 12 throw new UnsupportedError("'print' is not supported");
13 } 13 }
14 14
15 // Ignores printed lines.
16 _PrintClosure _nullPrintClosure = (String line) {
Ivan Posva 2013/12/12 12:11:49 ditto (types don't match)
floitsch 2013/12/12 21:08:37 moved to test file.
17 /* do nothing. */
18 };
19
15 // _printClosure can be overwritten by the embedder to supply a different 20 // _printClosure can be overwritten by the embedder to supply a different
16 // print implementation. 21 // print implementation.
17 _PrintClosure _printClosure = _unsupportedPrint; 22 _PrintClosure _printClosure = _unsupportedPrint;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698