extensions: clean up hiding/showing of developer controls.

chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(dbeam): test for loading upacked extensions?
 
 GEN('#include "chrome/browser/ui/webui/extensions/' +
     'extension_settings_browsertest.h"');
 
 /**
@@ skipping 56 matching lines @@
 function AsyncExtensionSettingsWebUITest() {}
 
 AsyncExtensionSettingsWebUITest.prototype = {
   __proto__: ExtensionSettingsWebUITest.prototype,
 
   /** @override */
   isAsync: true,
 };
 
 TEST_F('AsyncExtensionSettingsWebUITest', 'testDeveloperModeA11y', function() {
-  var devControl = $('dev-controls');
+  var devControls = $('dev-controls');
 
   // Make sure developer controls are hidden before checkbox is clicked.
-  assertTrue(devControl.hidden);
+  assertEquals(0, devControls.offsetHeight);
   $('toggle-dev-on').click();
 
   document.addEventListener('webkitTransitionEnd', function f(e) {
-    if (e.target == devControl) {
+    if (e.target == devControls) {
       // Make sure developer controls are not hidden after checkbox is clicked.
-      assertFalse(devControl.hidden);
+      assertGT(devControls.offsetHeight, 0);
 
       document.removeEventListener(f, 'webkitTransitionEnd');
       testDone();
     }
   });
-  ensureTransitionEndEvent(devControl, 4000);
+  ensureTransitionEndEvent(devControls, 4000);
 });
 
 /**
  * TestFixture for extension settings WebUI testing (commands config edition).
  * @extends {testing.Test}
  * @constructor
  */
 function ExtensionSettingsCommandsConfigWebUITest() {}
 
 ExtensionSettingsCommandsConfigWebUITest.prototype = {
@@ skipping 32 matching lines @@
   testGenPreamble: function() {
     GEN('  InstallGoodExtension();');
   }
 };
 
 TEST_F('ExtensionSettingsWebUITestWithExtensionInstalled',
        'baseAccessibilityIsOk', function() {
   assertEquals(this.browsePreload, document.location.href);
   this.runAccessibilityAudit();
 });