Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 887803002: Provide original URLs for next page detection in dom_distiller (Closed)

Created:
5 years, 10 months ago by wychen
Modified:
5 years, 10 months ago
Reviewers:
cjhopman, kuan, nyquist
CC:
chromium-reviews, nyquist
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide original URLs for next page detection in dom_distiller Option --original-url(s) is used instead of --original-domain(s) in eval server. Roll DomDistillerJS Picked up changes: 8c015c1 Mock Window.Location.getHref() in PagingLinksFinderTest BUG=425952 Committed: https://crrev.com/2268810ed4c2f08cc4113f21fba1f3043cdf2364 Cr-Commit-Position: refs/heads/master@{#315908}

Patch Set 1 #

Patch Set 2 : rebase, and use " " as delimiter instead of " #

Patch Set 3 : roll #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -205 lines) Patch
M components/dom_distiller/standalone/content_extractor.cc View 1 9 chunks +34 lines, -31 lines 0 comments Download
M third_party/dom_distiller_js/README.chromium View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/package/js/domdistiller.js View 1 2 1 chunk +169 lines, -167 lines 0 comments Download
M third_party/dom_distiller_js/package/proto/dom_distiller.proto View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/dom_distiller_js/package/proto_gen/third_party/dom_distiller_js/dom_distiller_json_converter.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
wychen
PTAL
5 years, 10 months ago (2015-01-29 23:27:14 UTC) #2
cjhopman
lgtm
5 years, 10 months ago (2015-01-30 22:38:24 UTC) #3
wychen
Use " " as delimiter instead of ";". The counterpart in google3 is updated as ...
5 years, 10 months ago (2015-02-11 21:37:28 UTC) #4
nyquist
lgtm
5 years, 10 months ago (2015-02-11 23:46:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887803002/40001
5 years, 10 months ago (2015-02-11 23:49:31 UTC) #8
commit-bot: I haz the power
Failed to apply patch for third_party/dom_distiller_js/README.chromium: While running git apply --index -3 -p1; error: patch ...
5 years, 10 months ago (2015-02-12 00:55:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887803002/60001
5 years, 10 months ago (2015-02-12 01:10:19 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-12 02:11:56 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 02:12:27 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2268810ed4c2f08cc4113f21fba1f3043cdf2364
Cr-Commit-Position: refs/heads/master@{#315908}

Powered by Google App Engine
This is Rietveld 408576698