Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 887793002: Implement PointerEvent#dx (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Implement PointerEvent#dx In this CL, the event handler keeps track of the delta from the previous pointer position so authors don't have to. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/110810e30e1087f5e5050b983ba4a2f2c95a8f15

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : Another nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -41 lines) Patch
M sky/engine/core/events/PointerEvent.h View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/engine/core/events/PointerEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/frame/NewEventHandler.h View 2 chunks +9 lines, -3 lines 0 comments Download
M sky/engine/core/frame/NewEventHandler.cpp View 1 2 3 chunks +29 lines, -24 lines 0 comments Download
M sky/engine/public/platform/WebInputEvent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/examples/appish.sky View 1 2 1 chunk +10 lines, -1 line 0 comments Download
M sky/examples/example-scaffold.sky View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M sky/framework/sky-drawer.sky View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-01-29 21:05:00 UTC) #1
eseidel
lgtm
5 years, 10 months ago (2015-01-29 21:16:18 UTC) #2
abarth-chromium
5 years, 10 months ago (2015-01-29 21:23:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
110810e30e1087f5e5050b983ba4a2f2c95a8f15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698