Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 887753002: roll gyp 2028:2029 (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

roll gyp 2028:2029 r2029: mac: Followup to ZERO_AR_DATE, touch the -o archive, rather than expecting only one TBR=thakis@chromium.org BUG=342974, 451499 Committed: https://crrev.com/178b2029270570c7aaa7907d9a3dc1d03836ee22 Cr-Commit-Position: refs/heads/master@{#313757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
scottmg
5 years, 10 months ago (2015-01-29 18:29:27 UTC) #1
Nico
lgtm
5 years, 10 months ago (2015-01-29 18:30:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887753002/1
5 years, 10 months ago (2015-01-29 18:30:51 UTC) #4
Nico
On 2015/01/29 18:30:32, Nico wrote: > lgtm (btw, it's still touching only one archive, it's ...
5 years, 10 months ago (2015-01-29 18:31:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 19:28:03 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 19:29:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/178b2029270570c7aaa7907d9a3dc1d03836ee22
Cr-Commit-Position: refs/heads/master@{#313757}

Powered by Google App Engine
This is Rietveld 408576698