Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 887743002: ozone: evdev: Set modifier flags on touch events (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
lanwei, Rick Byers
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Set modifier flags on touch events This fixes a regression vs X11 where all touch events are missing modifier flags. BUG=450650 TEST=Open http://www.rbyers.net/eventTest.html on link, hold shift, and tap the touchscreen. Page shows "shift" on the click event line. Committed: https://crrev.com/ec64091f736c8ba04a65b518c802ffd0d7b35386 Cr-Commit-Position: refs/heads/master@{#313788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
spang
5 years, 10 months ago (2015-01-29 18:18:28 UTC) #2
Rick Byers
thanks, lgtm worth adding a test do you think? It's so easy not to notice ...
5 years, 10 months ago (2015-01-29 18:27:26 UTC) #3
Rick Byers
On 2015/01/29 18:27:26, Rick Byers wrote: > thanks, lgtm > > worth adding a test ...
5 years, 10 months ago (2015-01-29 18:28:47 UTC) #4
spang
On 2015/01/29 18:28:47, Rick Byers wrote: > On 2015/01/29 18:27:26, Rick Byers wrote: > > ...
5 years, 10 months ago (2015-01-29 18:37:18 UTC) #5
Rick Byers
On 2015/01/29 18:37:18, spang wrote: > On 2015/01/29 18:28:47, Rick Byers wrote: > > On ...
5 years, 10 months ago (2015-01-29 18:40:05 UTC) #6
lanwei
LGTM, thank you for fixing it in such a short time!
5 years, 10 months ago (2015-01-29 19:26:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887743002/1
5 years, 10 months ago (2015-01-29 20:59:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 21:03:01 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 21:04:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec64091f736c8ba04a65b518c802ffd0d7b35386
Cr-Commit-Position: refs/heads/master@{#313788}

Powered by Google App Engine
This is Rietveld 408576698