Issue 88773002: DM: write failed comparison mode .pngs one more level deep in the tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88773002: DM: write failed comparison mode .pngs one more level deep in the tree. (Closed)

Created:
7 years ago by mtklein

Modified:
7 years ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

DM: write failed comparison mode .pngs one more level deep in the tree. E.g. instead of having to compare /tmp/dm/565/optimizations.png vs. /tmp/dm/replay/optimizations_565.png it's now /tmp/dm/565/optimizations.png vs. /tmp/dm/replay/565/optimizations.png This lets working with skdiff go a lot more smoothly. BUG= R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=12402

Patch Set 1 #

Patch Set 2 : rebase onto 88543002 #

Patch Set 3 : add comments and test SkStrSplit #

Patch Set 4 : oops, re-rebase #

Patch Set 5 : reword #

Patch Set 6 : add makeDirOrFail #

Patch Set 7 : rebase to head #

Patch Set 8 : depth() instead #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -41 lines)			Patch
M	dm/DM.cpp	View		3 chunks	+2 lines, -14 lines	0 comments	Download
M	dm/DMTask.h	View	1 2 3 4 5 6 7	3 chunks	+6 lines, -1 line	0 comments	Download
M	dm/DMTask.cpp	View	1 2 3 4 5 6 7	1 chunk	+6 lines, -5 lines	0 comments	Download
M	dm/DMWriteTask.h	View	1 2 3 4 5 6 7	3 chunks	+6 lines, -2 lines	0 comments	Download
M	dm/DMWriteTask.cpp	View	1 2 3 4 5 6 7	1 chunk	+32 lines, -19 lines	0 comments	Download
M	include/core/SkString.h	View	1 2 3 4 5 6	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/core/SkString.cpp	View	1 2 3 4 5 6	1 chunk	+12 lines, -0 lines	0 comments	Download
M	tests/StringTest.cpp	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #8 manually as r12402 (presubmit successful).

Expand Messages | Collapse Messages