Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 887693002: Lower Received MIME type when creating a response blob. (Closed)

Created:
5 years, 10 months ago by Paritosh Kumar
Modified:
5 years, 10 months ago
CC:
blink-reviews, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Lower Received MIME type when creating a response blob. As per specs: http://xhr.spec.whatwg.org/#final-mime-type Created Blob response must have a lower case MIME type. BUG=402419 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189784

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
A LayoutTests/http/tests/xmlhttprequest/response-blob-mimetype.html View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/xmlhttprequest/response-blob-mimetype-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Paritosh Kumar
@tyoshino: Please have a look.
5 years, 10 months ago (2015-01-29 14:08:01 UTC) #2
tyoshino (SeeGerritForStatus)
looks good. please write a test. You can use this. http://localhost:8000/dom/resources/send-mime-type.php
5 years, 10 months ago (2015-02-03 12:58:01 UTC) #3
Paritosh Kumar
Thanks tyoshino. Apologize for delay, added a test. Please have a look.
5 years, 10 months ago (2015-02-06 07:15:10 UTC) #4
tyoshino (SeeGerritForStatus)
lgtm +kouhei https://codereview.chromium.org/887693002/diff/20001/LayoutTests/http/tests/xmlhttprequest/response-blob-mimetype.html File LayoutTests/http/tests/xmlhttprequest/response-blob-mimetype.html (right): https://codereview.chromium.org/887693002/diff/20001/LayoutTests/http/tests/xmlhttprequest/response-blob-mimetype.html#newcode10 LayoutTests/http/tests/xmlhttprequest/response-blob-mimetype.html:10: 1 blank line https://codereview.chromium.org/887693002/diff/20001/LayoutTests/http/tests/xmlhttprequest/response-blob-mimetype.html#newcode34 LayoutTests/http/tests/xmlhttprequest/response-blob-mimetype.html:34: remove this ...
5 years, 10 months ago (2015-02-09 05:39:45 UTC) #6
tyoshino (SeeGerritForStatus)
On 2015/02/09 05:39:45, tyoshino wrote: > lgtm > > +kouhei Kouhei, please never mind.
5 years, 10 months ago (2015-02-09 05:40:17 UTC) #7
kouhei (in TOK)
lgtm
5 years, 10 months ago (2015-02-09 05:40:48 UTC) #8
tyoshino (SeeGerritForStatus)
On 2015/02/09 05:40:48, kouhei wrote: > lgtm Thanks
5 years, 10 months ago (2015-02-09 05:41:04 UTC) #9
Paritosh Kumar
On 2015/02/09 05:41:04, tyoshino wrote: > On 2015/02/09 05:40:48, kouhei wrote: > > lgtm > ...
5 years, 10 months ago (2015-02-09 05:53:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887693002/40001
5 years, 10 months ago (2015-02-09 05:55:39 UTC) #13
tyoshino (SeeGerritForStatus)
lgtm ps3
5 years, 10 months ago (2015-02-09 06:22:25 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 07:11:52 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189784

Powered by Google App Engine
This is Rietveld 408576698