Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2423)

Unified Diff: chrome/installer/mini_installer.gyp

Issue 887673003: Add support for create_installer_archive.py to generate a depfile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/tools/build/win/create_installer_archive.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mini_installer.gyp
diff --git a/chrome/installer/mini_installer.gyp b/chrome/installer/mini_installer.gyp
index e6b0ca7cc8de3a0854f4578dcc1733d79df81eba..f2caec6db1d0cfd75e7f938d64b1bb1de494c596 100644
--- a/chrome/installer/mini_installer.gyp
+++ b/chrome/installer/mini_installer.gyp
@@ -192,7 +192,7 @@
'component_build_flag': '',
},
'outputs': [
- '<(PRODUCT_DIR)/<(RULE_INPUT_NAME).packed.7z',
scottmg 2015/01/29 23:32:41 this expanded to "chrome.release.packed.7z" which
+ '<(PRODUCT_DIR)/chrome.packed.7z',
],
}],
['disable_nacl==1', {
@@ -243,11 +243,13 @@
'outputs': [
# Also note that chrome.packed.7z is defined as an output in a
# conditional above.
- 'xxx2.out',
scottmg 2015/01/29 23:32:41 this was to force an always-build which we're tryi
- '<(PRODUCT_DIR)/<(RULE_INPUT_NAME).7z',
scottmg 2015/01/29 23:32:41 same as .packed.7z above
+ '<(PRODUCT_DIR)/chrome.7z',
'<(PRODUCT_DIR)/setup.ex_',
'<(INTERMEDIATE_DIR)/packed_files.rc',
],
+ 'depfile': [
+ '<(INTERMEDIATE_DIR)/installer_archive.d',
scottmg 2015/01/29 23:32:41 this doesn't work yet (gyp only supports it on act
+ ],
'action': [
'python',
'<(create_installer_archive_py_path)',
@@ -255,6 +257,7 @@
'--staging_dir', '<(INTERMEDIATE_DIR)',
'--input_file', '<(RULE_INPUT_PATH)',
'--resource_file_path', '<(INTERMEDIATE_DIR)/packed_files.rc',
+ '--depfile', '<(INTERMEDIATE_DIR)/installer_archive.d',
'<(enable_hidpi_flag)',
'<(component_build_flag)',
'<(target_arch_flag)',
« no previous file with comments | « no previous file | chrome/tools/build/win/create_installer_archive.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698