Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Unified Diff: Source/modules/accessibility/AXRenderObject.cpp

Issue 887643003: Changed accessibility properies to meet W3C standard. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added test expectation for Android Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXRenderObject.cpp
diff --git a/Source/modules/accessibility/AXRenderObject.cpp b/Source/modules/accessibility/AXRenderObject.cpp
index a7c75232694e36186a0b8961e8e66d5df2346858..0f83e0032cd8a4b74599b9bd04a61661c6e57662 100644
--- a/Source/modules/accessibility/AXRenderObject.cpp
+++ b/Source/modules/accessibility/AXRenderObject.cpp
@@ -896,7 +896,6 @@ String AXRenderObject::stringValue() const
if (isPasswordFieldAndShouldHideValue())
return String();
- RenderBoxModelObject* cssBox = renderBoxModelObject();
if (ariaRoleAttribute() == StaticTextRole) {
String staticText = text();
@@ -908,7 +907,7 @@ String AXRenderObject::stringValue() const
if (m_renderer->isText())
return textUnderElement();
- if (cssBox && cssBox->isMenuList()) {
+ if (isHTMLSelectElement(m_renderer->node())) {
dmazzoni 2015/02/18 19:01:38 As I commented before, I don't think we should be
// RenderMenuList will go straight to the text() of its selected item.
// This has to be overridden in the case where the selected item has an ARIA label.
HTMLSelectElement* selectElement = toHTMLSelectElement(m_renderer->node());
@@ -919,7 +918,7 @@ String AXRenderObject::stringValue() const
if (!overriddenDescription.isNull())
return overriddenDescription;
}
- return toRenderMenuList(m_renderer)->text();
+ return selectElement->value();
}
if (m_renderer->isListMarker())
« no previous file with comments | « Source/modules/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698