Chromium Code Reviews| Index: Source/modules/accessibility/AXRenderObject.cpp |
| diff --git a/Source/modules/accessibility/AXRenderObject.cpp b/Source/modules/accessibility/AXRenderObject.cpp |
| index a7c75232694e36186a0b8961e8e66d5df2346858..0f83e0032cd8a4b74599b9bd04a61661c6e57662 100644 |
| --- a/Source/modules/accessibility/AXRenderObject.cpp |
| +++ b/Source/modules/accessibility/AXRenderObject.cpp |
| @@ -896,7 +896,6 @@ String AXRenderObject::stringValue() const |
| if (isPasswordFieldAndShouldHideValue()) |
| return String(); |
| - RenderBoxModelObject* cssBox = renderBoxModelObject(); |
| if (ariaRoleAttribute() == StaticTextRole) { |
| String staticText = text(); |
| @@ -908,7 +907,7 @@ String AXRenderObject::stringValue() const |
| if (m_renderer->isText()) |
| return textUnderElement(); |
| - if (cssBox && cssBox->isMenuList()) { |
| + if (isHTMLSelectElement(m_renderer->node())) { |
|
dmazzoni
2015/02/18 19:01:38
As I commented before, I don't think we should be
|
| // RenderMenuList will go straight to the text() of its selected item. |
| // This has to be overridden in the case where the selected item has an ARIA label. |
| HTMLSelectElement* selectElement = toHTMLSelectElement(m_renderer->node()); |
| @@ -919,7 +918,7 @@ String AXRenderObject::stringValue() const |
| if (!overriddenDescription.isNull()) |
| return overriddenDescription; |
| } |
| - return toRenderMenuList(m_renderer)->text(); |
| + return selectElement->value(); |
| } |
| if (m_renderer->isListMarker()) |