Changed accessibility properies to meet W3C standard.

Source/modules/accessibility/AXRenderObject.cpp

 /*
 * Copyright (C) 2008 Apple Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 262 matching lines @@
     if ((m_ariaRole = determineAriaRoleAttribute()) != UnknownRole)
         return m_ariaRole;
 
     Node* node = m_renderer->node();
     RenderBoxModelObject* cssBox = renderBoxModelObject();
 
     if ((cssBox && cssBox->isListItem()) || isHTMLLIElement(node))
         return ListItemRole;
     if (m_renderer->isListMarker())
         return ListMarkerRole;
+    if (isHTMLSelectElement(node)) {
+        HTMLSelectElement& selectElement = toHTMLSelectElement(*node);
+        return (selectElement.multiple() || selectElement.size() > 1 ) ? ListBoxRole : PopUpButtonRole;

[dmazzoni, 2015/01/29 16:28:29]

I don't think this will return the correct result on all platforms.

On Android, for example, a <select> is a PopUpButton under all of these
circumstances.

That's why it's better for AXRenderObject to check what RenderObject we have,
and as a fallback, AXNodeObject checks what HTML element we have.

[m.lapinski, 2015/01/30 10:46:21]

According to standard (working draft)
http://www.w3.org/TR/html-aapi/#el-select-listbox
Accesibility role depends on these conditions so i did it this way. I'll remove
it but it will cause failing canvas-fallback-content-2.html layout test for
android.

[dmazzoni, 2015/02/02 19:49:25]

Yeah, I think we need to fix the layout test so that it's allowed to have
different output on Android. There's a system for that - the Android-specific
test result goes in a file like:
LayoutTests/platform/android/accessibility/canvas-fallback-2-expected.txt

+    }
     if (m_renderer->isBR())
         return LineBreakRole;
     if (isHTMLLegendElement(node))
         return LegendRole;
     if (m_renderer->isText())
         return StaticTextRole;
     if (cssBox && isImageOrAltText(cssBox, node)) {
         if (node && node->isLink())
             return ImageMapRole;
         if (isHTMLInputElement(node))
@@ skipping 596 matching lines @@
 }
 
 String AXRenderObject::stringValue() const
 {
     if (!m_renderer)
         return String();
 
     if (isPasswordFieldAndShouldHideValue())
         return String();
 
-    RenderBoxModelObject* cssBox = renderBoxModelObject();
-
     if (ariaRoleAttribute() == StaticTextRole) {
         String staticText = text();
         if (!staticText.length())
             staticText = textUnderElement();
         return staticText;
     }
 
     if (m_renderer->isText())
         return textUnderElement();
 
-    if (cssBox && cssBox->isMenuList()) {
+    if (isHTMLSelectElement(m_renderer->node())) {
         // RenderMenuList will go straight to the text() of its selected item.
         // This has to be overridden in the case where the selected item has an ARIA label.
         HTMLSelectElement* selectElement = toHTMLSelectElement(m_renderer->node());
         int selectedIndex = selectElement->selectedIndex();
         const WillBeHeapVector<RawPtrWillBeMember<HTMLElement>>& listItems = selectElement->listItems();
         if (selectedIndex >= 0 && static_cast<size_t>(selectedIndex) < listItems.size()) {
             const AtomicString& overriddenDescription = listItems[selectedIndex]->fastGetAttribute(aria_labelAttr);
             if (!overriddenDescription.isNull())
                 return overriddenDescription;
         }
-        return toRenderMenuList(m_renderer)->text();
+        return selectElement->value();
     }
 
     if (m_renderer->isListMarker())
         return toRenderListMarker(m_renderer)->text();
 
     if (isWebArea()) {
         // FIXME: Why would a renderer exist when the Document isn't attached to a frame?
         if (m_renderer->frame())
             return String();
 
@@ skipping 1487 matching lines @@
         if (label && label->renderer()) {
             LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementRect();
             result.unite(labelRect);
         }
     }
 
     return result;
 }
 
 } // namespace blink