Let cros_power_monitor use dump_power_status

Let cros_power_monitor use dump_power_status

BUG=445645
TEST=tools/perf/run_benchmark --browser=cros-chrome --remote=$device robohornet_pro
TEST=tools/telemetry/run_tests telemetry.core.platform.power_monitor.cros_power_monitor_unittest

Committed: https://crrev.com/4e4cb1bc77f987c30d94047714136a206afcc616
Cr-Commit-Position: refs/heads/master@{#313867}

[hashimoto, 2015-01-29 12:17:56]

Patchset #1 (id:1) has been deleted

[hashimoto, 2015-01-29 12:18:09]

hashimoto@chromium.org changed reviewers:
+ achuith@chromium.org

[achuithb, 2015-01-29 19:46:58]

achuith@chromium.org changed reviewers:
+ derat@chromium.org

[achuithb, 2015-01-29 19:46:58]

Dan, can you also please take a look?

https://codereview.chromium.org/887613002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py
(right):

https://codereview.chromium.org/887613002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py:112:
m = re.match(r'(\S+)\s+(\S+)', ln)
Please add a comment with sample output of dump_power_status so this regex is a
little clearer.

[Daniel Erat, 2015-01-29 20:41:00]

lgtm with a comment

https://codereview.chromium.org/887613002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py
(right):

https://codereview.chromium.org/887613002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py:112:
m = re.match(r'(\S+)\s+(\S+)', ln)
On 2015/01/29 19:46:58, achuithb wrote:
> Please add a comment with sample output of dump_power_status so this regex is
a
> little clearer.

a regex seems like overkill here; just use ln.split() and assert that you got
two strings

[achuithb, 2015-01-29 20:48:33]

lgtm with Dan's suggested change.

[Daniel Erat, 2015-01-29 22:34:27]

(i promise that dump_power_status's output to stdout will never get more
complicated than newline-separated data, with a key consisting of lowercase
letters and underscores, whitespace, and then an integer or floating-point
number on each line) :-)

[hashimoto, 2015-01-30 03:25:35]

https://codereview.chromium.org/887613002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py
(right):

https://codereview.chromium.org/887613002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py:112:
m = re.match(r'(\S+)\s+(\S+)', ln)
On 2015/01/29 20:41:00, Daniel Erat wrote:
> On 2015/01/29 19:46:58, achuithb wrote:
> > Please add a comment with sample output of dump_power_status so this regex
is
> a
> > little clearer.
> 
> a regex seems like overkill here; just use ln.split() and assert that you got
> two strings

Done.

[hashimoto, 2015-01-30 03:25:38]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2015-01-30 03:26:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/887613002/40001

[commit-bot: I haz the power, 2015-01-30 04:25:50]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-01-30 04:26:51]

Patchset 2 (id:??) landed as
https://crrev.com/4e4cb1bc77f987c30d94047714136a206afcc616
Cr-Commit-Position: refs/heads/master@{#313867}