Add Wi-Fi SSID to captive portal interstitial.

Add Wi-FI SSID to captive portal interstitial.

This CL adds Wi-Fi SSID to the captive portal interstitial on Mac and Linux, if the connection is Wi-Fi.
WiFiService isn't available on other platforms, so we will be using other mechanisms such as
NetworkChangeNotifier on those.

BUG=451272
Committed: https://crrev.com/a55e33a2c32be98c01d7bae90a7492964571b272
Cr-Commit-Position: refs/heads/master@{#314003}

[meacer, 2015-01-29 18:33:07]

meacer@chromium.org changed reviewers:
+ felt@chromium.org

[meacer, 2015-01-29 18:33:07]

felt: Can you PTAL?

[meacer, 2015-01-29 19:46:21]

On 2015/01/29 18:33:07, Mustafa Emre Acer wrote:
> felt: Can you PTAL?

I noticed two major bugs, please hold off the review for now.

[meacer, 2015-01-29 22:35:22]

Fixed some escaping issues, should be good now.

[felt, 2015-01-29 22:59:58]

https://codereview.chromium.org/887573002/diff/80001/chrome/browser/ssl/capti...
File chrome/browser/ssl/captive_portal_blocking_page.cc (right):

https://codereview.chromium.org/887573002/diff/80001/chrome/browser/ssl/capti...
chrome/browser/ssl/captive_portal_blocking_page.cc:130: if
(!is_wifi_connection_) {
nit: kind of a weird construction -- why not the other way?

if (is_wifi_connection_) {
} else {
}

and again below with the second wifi_ssid_.empty() check

https://codereview.chromium.org/887573002/diff/80001/chrome/browser/ssl/capti...
chrome/browser/ssl/captive_portal_blocking_page.cc:162: if
(!is_wifi_connection_) {
same here

https://codereview.chromium.org/887573002/diff/80001/chrome/browser/ssl/capti...
File chrome/browser/ssl/captive_portal_blocking_page.h (right):

https://codereview.chromium.org/887573002/diff/80001/chrome/browser/ssl/capti...
chrome/browser/ssl/captive_portal_blocking_page.h:44: void
SetWiFiSSIDForTesting(std::string wifi_ssid) {
const std::string& wifi_ssid ?

[meacer, 2015-01-29 23:53:29]

https://codereview.chromium.org/887573002/diff/80001/chrome/browser/ssl/capti...
File chrome/browser/ssl/captive_portal_blocking_page.cc (right):

https://codereview.chromium.org/887573002/diff/80001/chrome/browser/ssl/capti...
chrome/browser/ssl/captive_portal_blocking_page.cc:130: if
(!is_wifi_connection_) {
On 2015/01/29 22:59:57, felt wrote:
> nit: kind of a weird construction -- why not the other way?
> 
> if (is_wifi_connection_) {
> } else {
> }
> 
> and again below with the second wifi_ssid_.empty() check

Done.

https://codereview.chromium.org/887573002/diff/80001/chrome/browser/ssl/capti...
File chrome/browser/ssl/captive_portal_blocking_page.h (right):

https://codereview.chromium.org/887573002/diff/80001/chrome/browser/ssl/capti...
chrome/browser/ssl/captive_portal_blocking_page.h:44: void
SetWiFiSSIDForTesting(std::string wifi_ssid) {
On 2015/01/29 22:59:57, felt wrote:
> const std::string& wifi_ssid ?

Done.

[felt, 2015-01-30 01:15:39]

lgtm

[meacer, 2015-01-30 01:22:34]

meacer@chromium.org changed reviewers:
+ mef@chromium.org

[meacer, 2015-01-30 01:22:35]

+mef for chrome/browser/ssl/DEPS

[mef, 2015-01-30 17:23:06]

chrome/browser/ssl/DEPS lgtm

[meacer, 2015-01-30 21:16:58]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2015-01-30 21:18:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/887573002/100001

[commit-bot: I haz the power, 2015-01-30 22:04:57]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-01-30 22:05:58]

Patchset 6 (id:??) landed as
https://crrev.com/a55e33a2c32be98c01d7bae90a7492964571b272
Cr-Commit-Position: refs/heads/master@{#314003}