Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 887563006: [Reland] Support listening for available screens for multiple (Closed)

Created:
5 years, 10 months ago by imcheng (use chromium acct)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] Support listening for available screens for multiple Presentation URLs on a per frame basis. Reland of 906113002. Previously failed to build due to missing CONTENT_EXPORTs which are added in this patch. Tested locally by switching to building using shared_library, repro'ed the problem, then added the CONTENT_EXPORT and built successfully. Support listening for available screens for multiple Presentation URLs on a per frame basis. This is done by associating PresentationServiceImpl with the RenderFrameHost. When Presentation API requests are passed to PresentationServiceImpl, it will delegate to the embedder's Media Router along with the frame id via the PresentationServiceDelegate interface. Each PresentationServiceImpl also maintains a hash map of Presentation URLs currently registered to "context" objects. These objects wait for both result and renderer (i.e. callback) to both be ready before sending the result back to renderer / PresentationDispatcher. Furthermore, PresentationServiceImpl listens for changes to the RenderFrameHost. If an out of page navigation occurred or if RenderFrameHost is being destroyed, all current Presentation URLs are unregistered. Also added unit tests for PresentationSerivceImpl. BUG=412331 Committed: https://crrev.com/9f515d066350e9be283ae8a0a36a6cb29218d8de Cr-Commit-Position: refs/heads/master@{#315624}

Patch Set 1 #

Patch Set 2 : NON_EXPORTED_BASE #

Patch Set 3 : removed non_export_base from RenderFrameObserver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+612 lines, -24 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl.h View 1 1 chunk +122 lines, -11 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 1 chunk +175 lines, -4 lines 0 comments Download
A content/browser/presentation/presentation_service_impl_unittest.cc View 1 chunk +299 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/presentation_screen_availability_listener.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/public/browser/presentation_service_delegate.h View 3 chunks +6 lines, -5 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
imcheng
Avi, Anton: PTAL again, thanks. Previous patch crrev.com/906113002 was reverted due to linking error (Strangely ...
5 years, 10 months ago (2015-02-10 06:45:44 UTC) #2
Avi (use Gerrit)
On 2015/02/10 06:45:44, imcheng1 wrote: > Avi, Anton: PTAL again, thanks. Previous patch crrev.com/906113002 was ...
5 years, 10 months ago (2015-02-10 15:41:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887563006/40001
5 years, 10 months ago (2015-02-10 19:12:26 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-10 20:09:35 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 20:10:31 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9f515d066350e9be283ae8a0a36a6cb29218d8de
Cr-Commit-Position: refs/heads/master@{#315624}

Powered by Google App Engine
This is Rietveld 408576698