Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1872)

Unified Diff: Source/modules/websockets/WorkerWebSocketChannel.h

Issue 887463003: Turn WorkerLoaderProxy into a threadsafe, ref-counted object. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Clarify WorkerLoaderProxyProvider's obligations on shutdown Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/websockets/WorkerWebSocketChannel.h
diff --git a/Source/modules/websockets/WorkerWebSocketChannel.h b/Source/modules/websockets/WorkerWebSocketChannel.h
index c97ca2d84928ec7a86d78cf2d6a0d0e32e70276c..2f2067442d7053447cb226faaee3515ac7d90d03 100644
--- a/Source/modules/websockets/WorkerWebSocketChannel.h
+++ b/Source/modules/websockets/WorkerWebSocketChannel.h
@@ -83,7 +83,7 @@ public:
USING_GARBAGE_COLLECTED_MIXIN(Peer);
WTF_MAKE_NONCOPYABLE(Peer);
public:
- Peer(Bridge*, WorkerLoaderProxy&, WebSocketChannelSyncHelper*);
+ Peer(Bridge*, PassRefPtr<WorkerLoaderProxy>, WebSocketChannelSyncHelper*);
virtual ~Peer();
// sourceURLAtConnection and lineNumberAtConnection parameters may
@@ -116,7 +116,7 @@ public:
void initializeInternal(ExecutionContext*, const String& sourceURLAtConnection, unsigned lineNumberAtConnection);
Member<Bridge> m_bridge;
- WorkerLoaderProxy& m_loaderProxy;
+ RefPtr<WorkerLoaderProxy> m_loaderProxy;
Member<WebSocketChannel> m_mainWebSocketChannel;
Member<WebSocketChannelSyncHelper> m_syncHelper;
};
@@ -149,7 +149,7 @@ public:
Member<WebSocketChannelClient> m_client;
RefPtrWillBeMember<WorkerGlobalScope> m_workerGlobalScope;
- WorkerLoaderProxy& m_loaderProxy;
+ RefPtr<WorkerLoaderProxy> m_loaderProxy;
Member<WebSocketChannelSyncHelper> m_syncHelper;
Member<Peer> m_peer;
};
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerThread.cpp ('k') | Source/modules/websockets/WorkerWebSocketChannel.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698