Source/core/workers/DedicatedWorkerThread.h - Issue 887463003: Turn WorkerLoaderProxy into a threadsafe, ref-counted object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/DedicatedWorkerThread.h

Issue 887463003: Turn WorkerLoaderProxy into a threadsafe, ref-counted object. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Explicitly detach instead of using a weak abstraction Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/loader/WorkerThreadableLoader.cpp ('k') | Source/core/workers/DedicatedWorkerThread.cpp » ('j') | Source/core/workers/WorkerLoaderProxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/workers/DedicatedWorkerThread.h

diff --git a/Source/core/workers/DedicatedWorkerThread.h b/Source/core/workers/DedicatedWorkerThread.h

index 5f03f26f9edca069c8ffaf32416b13ac1a712f89..ac6fa4b2cae44089d32d3f16d0ddbe4c5e5f5240 100644

--- a/Source/core/workers/DedicatedWorkerThread.h

+++ b/Source/core/workers/DedicatedWorkerThread.h

@@ -40,7 +40,7 @@ class WorkerThreadStartupData;

class DedicatedWorkerThread final : public WorkerThread {

public:

- static PassRefPtr<DedicatedWorkerThread> create(WorkerLoaderProxy&, WorkerObjectProxy&, double timeOrigin, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData>);

+ static PassRefPtr<DedicatedWorkerThread> create(PassRefPtr<WorkerLoaderProxy>, WorkerObjectProxy&, double timeOrigin, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData>);

WorkerObjectProxy& workerObjectProxy() const { return m_workerObjectProxy; }

virtual ~DedicatedWorkerThread();

@@ -49,7 +49,7 @@ protected:

virtual void postInitialize() override;

private:

- DedicatedWorkerThread(WorkerLoaderProxy&, WorkerObjectProxy&, double timeOrigin, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData>);

+ DedicatedWorkerThread(PassRefPtr<WorkerLoaderProxy>, WorkerObjectProxy&, double timeOrigin, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData>);

WorkerObjectProxy& m_workerObjectProxy;

double m_timeOrigin;

« no previous file with comments | « Source/core/loader/WorkerThreadableLoader.cpp ('k') | Source/core/workers/DedicatedWorkerThread.cpp » ('j') | Source/core/workers/WorkerLoaderProxy.h » ('J')