Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 887453002: [DevTools] DevToolsEmbedderMessageDispatcher: variadic implementation of RegisterHandler (Closed)

Created:
5 years, 10 months ago by vkuzkokov
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez, dgozman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] DevToolsEmbedderMessageDispatcher: variadic implementation of RegisterHandler BUG= Committed: https://crrev.com/12d80f9e9a30053a16c4d9564a06d1ca6c3a7a55 Cr-Commit-Position: refs/heads/master@{#313750}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Tuple -> ParamTuple #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -125 lines) Patch
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 3 chunks +45 lines, -125 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
vkuzkokov
5 years, 10 months ago (2015-01-28 17:47:25 UTC) #2
dgozman
Tom is the right reviewer for this file. https://codereview.chromium.org/887453002/diff/1/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc File chrome/browser/devtools/devtools_embedder_message_dispatcher.cc (right): https://codereview.chromium.org/887453002/diff/1/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc#newcode77 chrome/browser/devtools/devtools_embedder_message_dispatcher.cc:77: tail.template ...
5 years, 10 months ago (2015-01-29 10:43:44 UTC) #4
vkuzkokov
https://codereview.chromium.org/887453002/diff/1/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc File chrome/browser/devtools/devtools_embedder_message_dispatcher.cc (right): https://codereview.chromium.org/887453002/diff/1/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc#newcode77 chrome/browser/devtools/devtools_embedder_message_dispatcher.cc:77: tail.template Apply<H, As..., T>(handler, args..., head); On 2015/01/29 10:43:44, ...
5 years, 10 months ago (2015-01-29 16:11:32 UTC) #5
Tom Sepez
lgtm https://codereview.chromium.org/887453002/diff/1/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc File chrome/browser/devtools/devtools_embedder_message_dispatcher.cc (right): https://codereview.chromium.org/887453002/diff/1/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc#newcode52 chrome/browser/devtools/devtools_embedder_message_dispatcher.cc:52: struct Tuple { nit: worry about confusion with ...
5 years, 10 months ago (2015-01-29 17:33:04 UTC) #6
vkuzkokov
https://codereview.chromium.org/887453002/diff/1/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc File chrome/browser/devtools/devtools_embedder_message_dispatcher.cc (right): https://codereview.chromium.org/887453002/diff/1/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc#newcode52 chrome/browser/devtools/devtools_embedder_message_dispatcher.cc:52: struct Tuple { On 2015/01/29 17:33:04, Tom Sepez wrote: ...
5 years, 10 months ago (2015-01-29 17:49:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887453002/20001
5 years, 10 months ago (2015-01-29 17:50:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 19:09:27 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 19:10:27 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/12d80f9e9a30053a16c4d9564a06d1ca6c3a7a55
Cr-Commit-Position: refs/heads/master@{#313750}

Powered by Google App Engine
This is Rietveld 408576698