Issue 887303002: Revert of Move npot resizing out of GrContext and simplify GrContext texture functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 887303002: Revert of Move npot resizing out of GrContext and simplify GrContext texture functions. (Closed)

Created:
5 years, 10 months ago by bsalomon

Modified:
5 years, 10 months ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Move npot resizing out of GrContext and simplify GrContext texture functions. (patchset #10 id:200001 of https://codereview.chromium.org/882223003/) Reason for revert: perf fix didn't fix the cr webgl conformance tests Original issue's description: > Move npot resizing out of GrContext and simplify GrContext texture functions. > > Committed: https://skia.googlesource.com/skia/+/8a8100349105c8c6de39fcb34e47679da7a67f54 > > Committed: https://skia.googlesource.com/skia/+/6c96672491b04cb782bce8fee778124df66524a0 TBR=robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/e137db8569e7a10d809980609688b3acfaec612a

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+435 lines, -346 lines)			Patch
M	include/gpu/GrContext.h	View	4 chunks	+68 lines, -41 lines	0 comments	Download
M	include/gpu/GrPaint.h	View	1 chunk	+11 lines, -3 lines	0 comments	Download
M	include/gpu/GrResourceKey.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/gpu/GrTypes.h	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/effects/SkBlurMaskFilter.cpp	View	4 chunks	+18 lines, -20 lines	0 comments	Download
M	src/effects/SkColorCubeFilter.cpp	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	4 chunks	+243 lines, -32 lines	0 comments	Download
M	src/gpu/SkGr.cpp	View	14 chunks	+79 lines, -217 lines	0 comments	Download
M	src/gpu/effects/GrTextureStripAtlas.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/GLProgramsTest.cpp	View	1 chunk	+7 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

bsalomon

Created Revert of Move npot resizing out of GrContext and simplify GrContext texture functions.

5 years, 10 months ago (2015-02-01 04:09:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887303002/1

5 years, 10 months ago (2015-02-01 04:10:49 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-01 04:11:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e137db8569e7a10d809980609688b3acfaec612a