Small fix for PresentationScreenAvailabilityListener.

Small fix for PresentationScreenAvailabilityListener.

Also fixed PresentationServiceAvailabilityListener interface.
- fixed dtor naming and moved to public
- GetPresentationUrl() is now a const function

BUG=412331
Committed: https://crrev.com/6abc8722037c88df965d9ce6be5eddd15c6853ce
Cr-Commit-Position: refs/heads/master@{#314095}

[imcheng, 2015-01-31 21:19:41]

imcheng@chromium.org changed reviewers:
+ avayvod@chromium.org, avi@chromium.org, imcheng@chromium.org

[imcheng, 2015-01-31 21:19:42]

Avi, Anton: PTAL thanks! this is a small patch to converge the code in the
Chromium repo and the private repo. More patches to come next. Thanks.

[whywhat, 2015-01-31 23:43:42]

Please, see this thread:
https://groups.google.com/a/chromium.org/forum/#!topic/mojo-dev/pj0gevSNU74 to
see why I changed the name to CreateMojoService (that's why your patch fails to
compile on Windows as well). You could try the:

 #ifdef CreateService
 #undef CreateService
 #endif

In the .cc files

But i don't think this is the best approach either.

[imcheng, 2015-02-01 01:19:13]

Patchset #2 (id:20001) has been deleted

[imcheng, 2015-02-01 01:32:02]

You are right. It won't let me compile on win, even after I changed the
CreateService to take a param. My next guess would be to make it a member
function in order to prevent the rename from happening, but there's no reason we
have to do that. I have reverted the changes for now, so the only change
remaining is the PresentationScreenAvailabilityListener.

[whywhat, 2015-02-01 01:51:34]

On 2015/02/01 01:32:02, imcheng1 wrote:
> You are right. It won't let me compile on win, even after I changed the
> CreateService to take a param. My next guess would be to make it a member
> function in order to prevent the rename from happening, but there's no reason
we
> have to do that. I have reverted the changes for now, so the only change
> remaining is the PresentationScreenAvailabilityListener.

The problem is that CreateService is defined as a parameterless macro in Windows
headers. The preprocessor doesn't care if CreateService in our files is a static
method or a function or a variable name, it just replaces all occurrences to
CreateServiceW or CreateServiceA in all .cc files that include windows.h (e.g.
render_host_impl.cc).
I guess including windows.h in our presentaion_service_impl.cc file would "fix"
the compilation since the preprocessor would rename the definition of the method
too.

[Avi (use Gerrit), 2015-02-01 05:25:11]

On 2015/02/01 01:51:34, whywhat wrote:
> On 2015/02/01 01:32:02, imcheng1 wrote:
> > You are right. It won't let me compile on win, even after I changed the
> > CreateService to take a param. My next guess would be to make it a member
> > function in order to prevent the rename from happening, but there's no
reason
> we
> > have to do that. I have reverted the changes for now, so the only change
> > remaining is the PresentationScreenAvailabilityListener.
> 
> The problem is that CreateService is defined as a parameterless macro in
Windows
> headers. The preprocessor doesn't care if CreateService in our files is a
static
> method or a function or a variable name, it just replaces all occurrences to
> CreateServiceW or CreateServiceA in all .cc files that include windows.h (e.g.
> render_host_impl.cc).
> I guess including windows.h in our presentaion_service_impl.cc file would
"fix"
> the compilation since the preprocessor would rename the definition of the
method
> too.

When you get this Windows stuff sorted out, this lgtm.

[whywhat, 2015-02-01 09:49:25]

Thans Avi! Daniel removed the changes related to the Windows issue. We'll fix it
in some next CL.

lgtm for the rest of the changes.

[whywhat, 2015-02-01 09:49:30]

The CQ bit was checked by avayvod@chromium.org

[commit-bot: I haz the power, 2015-02-01 09:50:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/887293002/40001

[commit-bot: I haz the power, 2015-02-01 11:26:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-01 11:26:54]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[imcheng, 2015-02-01 18:10:14]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2015-02-01 18:10:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/887293002/40001

[commit-bot: I haz the power, 2015-02-01 19:01:18]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-02-01 19:02:35]

Patchset 2 (id:??) landed as
https://crrev.com/6abc8722037c88df965d9ce6be5eddd15c6853ce
Cr-Commit-Position: refs/heads/master@{#314095}