Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2386)

Unified Diff: media/filters/skcanvas_video_renderer.cc

Issue 887243003: Fix video->canvas with alpha in SW video->HW canvas case. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/skcanvas_video_renderer.cc
diff --git a/media/filters/skcanvas_video_renderer.cc b/media/filters/skcanvas_video_renderer.cc
index 743efc04f648c8fc4171fb50d2909bd4858fdf70..ca1c34b1ee713a848e984a125ecf01f7d3f4ff05 100644
--- a/media/filters/skcanvas_video_renderer.cc
+++ b/media/filters/skcanvas_video_renderer.cc
@@ -354,9 +354,10 @@ class VideoImageGenerator : public SkImageGenerator {
SkYUVColorSpace* color_space) override {
if (!frame_.get() || !IsYUV(frame_->format()) ||
// TODO(rileya): Skia currently doesn't support Rec709 YUV conversion,
- // Remove this case once it does. As-is we will fall back on the
- // pure-software path in this case.
- frame_->format() == VideoFrame::YV12HD) {
+ // or YUVA conversion. Remove this case once it does. As-is we will
+ // fall back on the pure-software path in this case.
+ frame_->format() == VideoFrame::YV12HD ||
+ frame_->format() == VideoFrame::YV12A) {
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698