Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 887223009: ppapi: VideoEncoder: Add proxy boilerplate (Closed)

Created:
5 years, 10 months ago by llandwerlin-old
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, jam, raymes+watch_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, bradnelson+warch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ppapi: VideoEncoder: Add proxy boilerplate BUG=455409 TEST=none Committed: https://crrev.com/377c2e7f1c22253804a1aa3810a687a31c493757 Cr-Commit-Position: refs/heads/master@{#315007}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Update after bbudge's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -10 lines) Patch
M chrome/browser/component_updater/ppapi_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/resource_creation_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/resource_creation_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ppapi/cpp/video_encoder.h View 6 chunks +9 lines, -5 lines 0 comments Download
M ppapi/cpp/video_encoder.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 2 chunks +5 lines, -0 lines 0 comments Download
A ppapi/proxy/video_encoder_resource.h View 1 1 chunk +62 lines, -0 lines 0 comments Download
A ppapi/proxy/video_encoder_resource.cc View 1 1 chunk +79 lines, -0 lines 0 comments Download
M ppapi/shared_impl/resource.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev_channel.h View 1 chunk +1 line, -0 lines 0 comments Download
A ppapi/thunk/ppb_video_encoder_api.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
llandwerlin-old
isherman@: Sorry, could you review again the metric file. dmichael@, bbudge@: Here is the rest ...
5 years, 10 months ago (2015-02-05 17:04:51 UTC) #2
bbudge
Looks good. I'll land the 'dev' channel fix so you can merge it in. https://codereview.chromium.org/887223009/diff/1/ppapi/proxy/video_encoder_resource.cc ...
5 years, 10 months ago (2015-02-05 18:40:52 UTC) #3
llandwerlin-old
https://codereview.chromium.org/887223009/diff/1/ppapi/proxy/video_encoder_resource.cc File ppapi/proxy/video_encoder_resource.cc (right): https://codereview.chromium.org/887223009/diff/1/ppapi/proxy/video_encoder_resource.cc#newcode1 ppapi/proxy/video_encoder_resource.cc:1: // Copyright (c) 2015 The Chromium Authors. All rights ...
5 years, 10 months ago (2015-02-05 22:17:36 UTC) #4
bbudge
LGTM Thanks for fixing up the C++ wrapper.
5 years, 10 months ago (2015-02-05 22:25:46 UTC) #5
Ilya Sherman
histograms.xml lgtm
5 years, 10 months ago (2015-02-06 00:39:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887223009/20001
5 years, 10 months ago (2015-02-06 02:50:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/23676)
5 years, 10 months ago (2015-02-06 04:51:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887223009/20001
5 years, 10 months ago (2015-02-06 09:37:53 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 12:15:55 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 12:17:27 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/377c2e7f1c22253804a1aa3810a687a31c493757
Cr-Commit-Position: refs/heads/master@{#315007}

Powered by Google App Engine
This is Rietveld 408576698