Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: ui/views/controls/webview/webview.cc

Issue 887203002: Revert of Ensure WebView notifies desktop automation on creation, destruction, and change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/webview/webview.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/webview/webview.cc
diff --git a/ui/views/controls/webview/webview.cc b/ui/views/controls/webview/webview.cc
index 203fbe266aa5fdb27221bde03f44fec6041204ef..2e4ba84fa000b8bd33675f371e1ff296849a1820 100644
--- a/ui/views/controls/webview/webview.cc
+++ b/ui/views/controls/webview/webview.cc
@@ -78,7 +78,7 @@
DCHECK(!is_embedding_fullscreen_widget_);
}
AttachWebContents();
- NotifyMaybeTextInputClientAndAccessibilityChanged();
+ NotifyMaybeTextInputClientChanged();
}
void WebView::SetEmbedFullscreenWidgetMode(bool enable) {
@@ -266,7 +266,7 @@
void WebView::RenderProcessExited(content::RenderProcessHost* host,
base::TerminationStatus status,
int exit_code) {
- NotifyMaybeTextInputClientAndAccessibilityChanged();
+ NotifyMaybeTextInputClientChanged();
}
void WebView::RenderProcessHostDestroyed(content::RenderProcessHost* host) {
@@ -293,11 +293,11 @@
// WebView, content::WebContentsObserver implementation:
void WebView::RenderViewReady() {
- NotifyMaybeTextInputClientAndAccessibilityChanged();
+ NotifyMaybeTextInputClientChanged();
}
void WebView::RenderViewDeleted(content::RenderViewHost* render_view_host) {
- NotifyMaybeTextInputClientAndAccessibilityChanged();
+ NotifyMaybeTextInputClientChanged();
}
void WebView::RenderViewHostChanged(content::RenderViewHost* old_host,
@@ -305,7 +305,7 @@
FocusManager* const focus_manager = GetFocusManager();
if (focus_manager && focus_manager->GetFocusedView() == this)
OnFocus();
- NotifyMaybeTextInputClientAndAccessibilityChanged();
+ NotifyMaybeTextInputClientChanged();
}
void WebView::WebContentsDestroyed() {
@@ -313,7 +313,7 @@
observing_render_process_host_->RemoveObserver(this);
observing_render_process_host_ = nullptr;
}
- NotifyMaybeTextInputClientAndAccessibilityChanged();
+ NotifyMaybeTextInputClientChanged();
}
void WebView::DidShowFullscreenWidget(int routing_id) {
@@ -332,11 +332,11 @@
}
void WebView::DidAttachInterstitialPage() {
- NotifyMaybeTextInputClientAndAccessibilityChanged();
+ NotifyMaybeTextInputClientChanged();
}
void WebView::DidDetachInterstitialPage() {
- NotifyMaybeTextInputClientAndAccessibilityChanged();
+ NotifyMaybeTextInputClientChanged();
}
////////////////////////////////////////////////////////////////////////////////
@@ -398,18 +398,14 @@
// the same. So, do not change attachment.
OnBoundsChanged(bounds());
}
- NotifyMaybeTextInputClientAndAccessibilityChanged();
-}
-
-void WebView::NotifyMaybeTextInputClientAndAccessibilityChanged() {
+ NotifyMaybeTextInputClientChanged();
+}
+
+void WebView::NotifyMaybeTextInputClientChanged() {
// Update the TextInputClient as needed; see GetTextInputClient().
FocusManager* const focus_manager = GetFocusManager();
if (focus_manager)
focus_manager->OnTextInputClientChanged(this);
-
-#if defined(OS_CHROMEOS)
- NotifyAccessibilityEvent(ui::AX_EVENT_CHILDREN_CHANGED, true);
-#endif // defined OS_CHROMEOS
}
content::WebContents* WebView::CreateWebContents(
« no previous file with comments | « ui/views/controls/webview/webview.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698