Issue 887193003: Add suggestions to the deps of chrome/browser/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 887193003: Add suggestions to the deps of chrome/browser/ui (Closed)

Created:
5 years, 10 months ago by brettw

Modified:
5 years, 10 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add suggestions to the deps of chrome/browser/ui The proto is used by some headers and the lack of dependency is causing some build flakiness. TBR=dpranke Committed: https://chromium.googlesource.com/chromium/src/+/47f77af24354054857d07a6790e61fc745b2ce41

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/ui/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/47f77af24354054857d07a6790e61fc745b2ce41 Cr-Commit-Position: refs/heads/master@{#314050}

5 years, 10 months ago (2015-01-31 06:11:45 UTC) #3

brettw

5 years, 10 months ago (2015-01-31 06:11:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
47f77af24354054857d07a6790e61fc745b2ce41 (presubmit successful).