Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 887153003: Add CVC icon to card unmasking prompt (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 10 months ago
CC:
browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CVC icon to card unmasking prompt (placeholder images inserted, bug 454009 filed) Also, move CardUnmaskPrompt.java to proper location. BUG=454009 Committed: https://crrev.com/5457d13ccfe081fe1ee353d5a4badaf775265d44 Cr-Commit-Position: refs/heads/master@{#314393}

Patch Set 1 #

Total comments: 2

Patch Set 2 : ems #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -307 lines) Patch
A + chrome/android/java/res/drawable-hdpi/cvc_icon.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-hdpi/cvc_icon_amex.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/cvc_icon.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/cvc_icon_amex.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xhdpi/cvc_icon.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xhdpi/cvc_icon_amex.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/cvc_icon.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/cvc_icon_amex.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxxhdpi/cvc_icon.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxxhdpi/cvc_icon_amex.png View Binary file 0 comments Download
A + chrome/android/java/res/layout/autofill_card_unmask_prompt.xml View 1 1 chunk +8 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java View 3 chunks +9 lines, -7 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java View 5 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/android/resource_id.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc View 2 chunks +4 lines, -1 line 0 comments Download
D ui/android/java/res/layout/autofill_card_unmask_prompt.xml View 1 chunk +0 lines, -79 lines 0 comments Download
D ui/android/java/src/org/chromium/ui/autofill/CardUnmaskPrompt.java View 1 chunk +0 lines, -215 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
Evan Stade
5 years, 10 months ago (2015-01-31 01:11:00 UTC) #2
newt (away)
lgtm https://codereview.chromium.org/887153003/diff/1/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml File chrome/android/java/res/layout/autofill_card_unmask_prompt.xml (right): https://codereview.chromium.org/887153003/diff/1/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml#newcode49 chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:49: android:ems="4" nit: put ems after layout_marginStart. layout_* attributes ...
5 years, 10 months ago (2015-01-31 01:42:48 UTC) #3
Evan Stade
https://codereview.chromium.org/887153003/diff/1/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml File chrome/android/java/res/layout/autofill_card_unmask_prompt.xml (right): https://codereview.chromium.org/887153003/diff/1/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml#newcode49 chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:49: android:ems="4" On 2015/01/31 01:42:48, newt wrote: > nit: put ...
5 years, 10 months ago (2015-01-31 02:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887153003/20001
5 years, 10 months ago (2015-01-31 02:11:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39632)
5 years, 10 months ago (2015-01-31 02:19:36 UTC) #8
Evan Stade
+aurimas for OWNERs on chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc
5 years, 10 months ago (2015-02-02 19:38:37 UTC) #10
aurimas (slooooooooow)
chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc LTGM
5 years, 10 months ago (2015-02-02 21:29:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887153003/20001
5 years, 10 months ago (2015-02-02 21:54:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39920)
5 years, 10 months ago (2015-02-02 21:59:36 UTC) #15
aurimas (slooooooooow)
On 2015/02/02 at 21:59:36, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit ...
5 years, 10 months ago (2015-02-02 22:04:59 UTC) #16
aurimas (slooooooooow)
I guess i'm not an owner, but aruslan@ is :)
5 years, 10 months ago (2015-02-02 22:05:27 UTC) #18
Evan Stade
On 2015/02/02 22:05:27, aurimas wrote: > I guess i'm not an owner, but aruslan@ is ...
5 years, 10 months ago (2015-02-03 19:54:39 UTC) #19
aruslan
Aforementioned change LGTM
5 years, 10 months ago (2015-02-03 20:04:37 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887153003/20001
5 years, 10 months ago (2015-02-03 20:07:22 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 20:11:41 UTC) #23
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 20:13:36 UTC) #24
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5457d13ccfe081fe1ee353d5a4badaf775265d44
Cr-Commit-Position: refs/heads/master@{#314393}

Powered by Google App Engine
This is Rietveld 408576698