Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 887143002: Completely remove SyncStatusHelper. (Closed)

Created:
5 years, 10 months ago by maxbogue
Modified:
5 years, 10 months ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Completely remove SyncStatusHelper. It was renamed to AndroidSyncSettings in http://crrev.com/845543005. Committed: https://crrev.com/8b497e74ddd1a3be65c311419a57307119473a53 Cr-Commit-Position: refs/heads/master@{#314427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -461 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java View 2 chunks +0 lines, -17 lines 0 comments Download
D sync/android/java/src/org/chromium/sync/notifier/SyncStatusHelper.java View 1 chunk +0 lines, -438 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
maxbogue
This one should also be good to go.
5 years, 10 months ago (2015-01-30 23:48:06 UTC) #2
nyquist
lgtm
5 years, 10 months ago (2015-02-03 18:26:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887143002/1
5 years, 10 months ago (2015-02-03 22:18:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 23:04:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 23:05:08 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8b497e74ddd1a3be65c311419a57307119473a53
Cr-Commit-Position: refs/heads/master@{#314427}

Powered by Google App Engine
This is Rietveld 408576698