Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: ui/gl/gl_bindings_autogen_gl.cc

Issue 887113003: Fix incorrect binding spec for multisampled_render_to_texture APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/generate_bindings.py ('k') | ui/gl/gl_bindings_autogen_mock.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_bindings_autogen_gl.cc
diff --git a/ui/gl/gl_bindings_autogen_gl.cc b/ui/gl/gl_bindings_autogen_gl.cc
index 642190c0e7a4eb208ddc2d1465c7ef38f72e4787..11383b15a15cbd7adccc7a9b25ee9c80dbd14342 100644
--- a/ui/gl/gl_bindings_autogen_gl.cc
+++ b/ui/gl/gl_bindings_autogen_gl.cc
@@ -1692,12 +1692,7 @@ void DriverGL::InitializeDynamicBindings(GLContext* context) {
}
debug_fn.glRenderbufferStorageMultisampleANGLEFn = 0;
- if (ver->IsAtLeastGL(3u, 0u) || ver->IsAtLeastGLES(3u, 0u)) {
- fn.glRenderbufferStorageMultisampleANGLEFn =
- reinterpret_cast<glRenderbufferStorageMultisampleANGLEProc>(
- GetGLProcAddress("glRenderbufferStorageMultisample"));
- DCHECK(fn.glRenderbufferStorageMultisampleANGLEFn);
- } else if (ext.b_GL_ANGLE_framebuffer_multisample) {
+ if (ext.b_GL_ANGLE_framebuffer_multisample) {
fn.glRenderbufferStorageMultisampleANGLEFn =
reinterpret_cast<glRenderbufferStorageMultisampleANGLEProc>(
GetGLProcAddress("glRenderbufferStorageMultisampleANGLE"));
@@ -1705,13 +1700,8 @@ void DriverGL::InitializeDynamicBindings(GLContext* context) {
}
debug_fn.glRenderbufferStorageMultisampleEXTFn = 0;
- if (ver->IsAtLeastGL(3u, 0u) || ver->IsAtLeastGLES(3u, 0u)) {
- fn.glRenderbufferStorageMultisampleEXTFn =
- reinterpret_cast<glRenderbufferStorageMultisampleEXTProc>(
- GetGLProcAddress("glRenderbufferStorageMultisample"));
- DCHECK(fn.glRenderbufferStorageMultisampleEXTFn);
no sievers 2015/02/03 21:39:41 The problem was caused by us falling into here on
- } else if (ext.b_GL_EXT_multisampled_render_to_texture ||
- ext.b_GL_EXT_framebuffer_multisample) {
+ if (ext.b_GL_EXT_multisampled_render_to_texture ||
+ ext.b_GL_EXT_framebuffer_multisample) {
fn.glRenderbufferStorageMultisampleEXTFn =
reinterpret_cast<glRenderbufferStorageMultisampleEXTProc>(
GetGLProcAddress("glRenderbufferStorageMultisampleEXT"));
« no previous file with comments | « ui/gl/generate_bindings.py ('k') | ui/gl/gl_bindings_autogen_mock.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698