Add factory for Android font manager.

Add factory for Android font manager.

This allows users to create an Android font manager with their own set
of fonts, or augment the system set. This will allow for removal of
the current globals which are used for a similar, but more constained,
purpose.

BUG=skia:2817, skia:3314, chromium:407340
Committed: https://skia.googlesource.com/skia/+/7fa87cd09f49f1ee9bc27e263038d0f0ae706241

[bungeman-skia, 2015-02-04 20:54:39]

bungeman@google.com changed reviewers:
+ djsollen@google.com, mtklein@google.com

[reed1, 2015-02-04 22:36:51]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-02-04 22:36:51]

https://codereview.chromium.org/887113002/diff/60001/include/ports/SkFontMgr_...
File include/ports/SkFontMgr_android.h (right):

https://codereview.chromium.org/887113002/diff/60001/include/ports/SkFontMgr_...
include/ports/SkFontMgr_android.h:23: SystemFontUse systemFontUse;
Lets follow our std fField name convention.

https://codereview.chromium.org/887113002/diff/60001/include/ports/SkFontMgr_...
include/ports/SkFontMgr_android.h:38: SK_API SkFontMgr*
SkFontMgr_New_Android(SkFontMgr_Android_CustomFonts* custom);
const* custom?

[bungeman-skia, 2015-02-04 22:45:31]

https://codereview.chromium.org/887113002/diff/60001/include/ports/SkFontMgr_...
File include/ports/SkFontMgr_android.h (right):

https://codereview.chromium.org/887113002/diff/60001/include/ports/SkFontMgr_...
include/ports/SkFontMgr_android.h:23: SystemFontUse systemFontUse;
On 2015/02/04 22:36:51, reed1 wrote:
> Lets follow our std fField name convention.

Done.

https://codereview.chromium.org/887113002/diff/60001/include/ports/SkFontMgr_...
include/ports/SkFontMgr_android.h:38: SK_API SkFontMgr*
SkFontMgr_New_Android(SkFontMgr_Android_CustomFonts* custom);
On 2015/02/04 22:36:51, reed1 wrote:
> const* custom?

Done.

[reed1, 2015-02-04 22:46:12]

public-api lgtm

[djsollen, 2015-02-04 23:11:07]

https://codereview.chromium.org/887113002/diff/80001/src/ports/SkFontMgr_andr...
File src/ports/SkFontMgr_android.cpp (right):

https://codereview.chromium.org/887113002/diff/80001/src/ports/SkFontMgr_andr...
src/ports/SkFontMgr_android.cpp:513: #define COMMA ,
what is the point of this define?  Just use a comma.

https://codereview.chromium.org/887113002/diff/80001/src/ports/SkFontMgr_andr...
src/ports/SkFontMgr_android.cpp:520: SkASSERT(     custom->fSystemFontUse <
SK_ARRAY_COUNT(SystemFontUseStrings));
nit: fix spacing

[bungeman-skia, 2015-02-04 23:32:11]

https://codereview.chromium.org/887113002/diff/80001/src/ports/SkFontMgr_andr...
File src/ports/SkFontMgr_android.cpp (right):

https://codereview.chromium.org/887113002/diff/80001/src/ports/SkFontMgr_andr...
src/ports/SkFontMgr_android.cpp:513: #define COMMA ,
On 2015/02/04 23:11:06, djsollen wrote:
> what is the point of this define?  Just use a comma.

SkDEBUGCODE is a macro, so any literal comma is seen as an argument separator. I
just want an array of strings whenever SkASSERT isn't def'ed away. I'll see if
there's any nicer looking way to do this, I suppose I could just use SK_DEBUG,
it seems nice to avoid directly using it.

https://codereview.chromium.org/887113002/diff/80001/src/ports/SkFontMgr_andr...
src/ports/SkFontMgr_android.cpp:520: SkASSERT(     custom->fSystemFontUse <
SK_ARRAY_COUNT(SystemFontUseStrings));
On 2015/02/04 23:11:07, djsollen wrote:
> nit: fix spacing

I'm just trying to show very obviously that I'm testing that the value is
between two other values. It would be nice if one could write

SkASSERT(0 <= custom->fSystemFontUse < SK_ARRAY_COUNT(SystemFontUseStrings));

and have it do the right thing. Maybe we have an 'inrange' somewhere for this?
I'd write it all on one line, but I think it's a little long then.

[bungeman-skia, 2015-02-04 23:47:51]

New patchsets have been uploaded after l-g-t-m from reed@google.com

[bungeman-skia, 2015-02-04 23:48:50]

https://codereview.chromium.org/887113002/diff/80001/src/ports/SkFontMgr_andr...
File src/ports/SkFontMgr_android.cpp (right):

https://codereview.chromium.org/887113002/diff/80001/src/ports/SkFontMgr_andr...
src/ports/SkFontMgr_android.cpp:513: #define COMMA ,
On 2015/02/04 23:11:06, djsollen wrote:
> what is the point of this define?  Just use a comma.

Done.

https://codereview.chromium.org/887113002/diff/80001/src/ports/SkFontMgr_andr...
src/ports/SkFontMgr_android.cpp:520: SkASSERT(     custom->fSystemFontUse <
SK_ARRAY_COUNT(SystemFontUseStrings));
On 2015/02/04 23:11:07, djsollen wrote:
> nit: fix spacing

Done.

[bungeman-skia, 2015-02-05 23:31:49]

At patch set 9, I think I've worked out all the bugs. Note that a very important
existing one is fixed in patch set 7.

[reed1, 2015-02-06 15:37:34]

lgtm

[bungeman-skia, 2015-02-06 15:52:42]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-02-06 15:53:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/887113002/160001

[commit-bot: I haz the power, 2015-02-06 15:59:23]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/7fa87cd09f49f1ee9bc27e263038d0f0ae706241