Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Issue 887093004: [Cleanup] Move the Easy Unlock metrics files out of the chromeos directory. (Closed)

Created:
5 years, 10 months ago by Ilya Sherman
Modified:
5 years, 10 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Move the Easy Unlock metrics files out of the chromeos directory. This is a cleanup change in preparation for [ http://crbug.com/450509 ], where metrics will be logged in non-ChromeOS-only code. BUG=450509 TEST=compiles R=tengs@chromium.org Committed: https://crrev.com/a3cbdfc51de0fb1c4fbd96cddd5699ca1707bc12 Cr-Commit-Position: refs/heads/master@{#314759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -134 lines) Patch
D chrome/browser/chromeos/login/easy_unlock/easy_unlock_metrics.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/chromeos/login/easy_unlock/easy_unlock_metrics.cc View 1 chunk +0 lines, -20 lines 0 comments Download
A + chrome/browser/signin/easy_unlock_metrics.h View 3 chunks +5 lines, -9 lines 0 comments Download
A + chrome/browser/signin/easy_unlock_metrics.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 4 chunks +23 lines, -25 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Ilya Sherman
5 years, 10 months ago (2015-02-05 02:02:53 UTC) #1
Tim Song
lgtm
5 years, 10 months ago (2015-02-05 02:36:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887093004/1
5 years, 10 months ago (2015-02-05 02:38:39 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/30867)
5 years, 10 months ago (2015-02-05 03:46:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887093004/1
5 years, 10 months ago (2015-02-05 04:04:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 04:58:19 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 04:59:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3cbdfc51de0fb1c4fbd96cddd5699ca1707bc12
Cr-Commit-Position: refs/heads/master@{#314759}

Powered by Google App Engine
This is Rietveld 408576698