Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 887093002: Rename CrWinClang(asan) to CrWinAsan. (Closed)

Created:
5 years, 10 months ago by Nico
Modified:
5 years, 10 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
tools
Visibility:
Public.

Description

Rename CrWinClang(asan) to CrWinAsan. The win/clang/asan component bot can't be called CrWinClang(asan/dll) since that causes path names to be too long for the build (because of http://crbug.com/399990), so it's called CrWinAsan(dll). For consistency, rename the existing static asan bot from CrWinClang(asan) to CrWinAsan. (Since the test list in the src/ directory also contains this name, there will be a short window where the bot won't know which tests to run. Also, the name change means we'll lose bot history. Since the bot is currently in great shape, we think that now is a good time to make this change.) BUG=448790 TBR=timurrrr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -588 lines) Patch
M masters/master.chromium.fyi/master.cfg View 3 chunks +4 lines, -4 lines 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/chromium_fyi.py View 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan.json View 4 chunks +6 lines, -6 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan_tester.json View 8 chunks +10 lines, -10 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_asan_.json View 1 chunk +0 lines, -239 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_asan__tester.json View 1 chunk +0 lines, -324 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
5 years, 10 months ago (2015-01-30 19:49:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887093002/1
5 years, 10 months ago (2015-01-30 19:50:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=293883
5 years, 10 months ago (2015-01-30 19:51:34 UTC) #5
Timur Iskhodzhanov
5 years, 10 months ago (2015-02-02 14:49:41 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698