Merge https://codereview.chromium.org/897973002/ and https://codereview.chromium.org/902753002/ to …

xfa/src/fxjse/src/runtime.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../foxitlib.h"
 #include "fxv8.h"
 #include "runtime.h"
 #include "scope_inline.h"
 static void FXJSE_KillV8()
 {
     v8::V8::Dispose();
 }
 void FXJSE_Initialize()
 {
     if(!CFXJSE_RuntimeData::g_RuntimeList) {
         CFXJSE_RuntimeData::g_RuntimeList = FX_NEW CFXJSE_RuntimeList;
     }
     static FX_BOOL bV8Initialized = FALSE;
     if (bV8Initialized) {
         return;
     }
     bV8Initialized = TRUE;
     atexit(FXJSE_KillV8);
     FX_LPCSTR szCmdFlags =
         "--harmony_proxies "
         "--block_concurrent_recompilation "
         ;
     v8::V8::SetFlagsFromString(szCmdFlags, FXSYS_strlen(szCmdFlags));

[jam, 2015/02/05 01:41:19]

I don't know if this works anymore

[jochen (gone - plz use gerrit), 2015/02/06 10:27:12]

this works in the sense that it sets the flag.

It doesn't work in the sense that the resulting behavior of V8 is broken, but
that was already the case before. We must not ship this code as long as it
depends on these flags.

[jun_fang, 2015/02/09 23:44:32]

Feedback from our developers, according to current design,
v8::V8::SetFlagsFromString(szCmdFlags, FXSYS_strlen(szCmdFlags)) shall run
before v8::V8::Initialize(). Otherwise, it doesn't take effect. We plan to
enhance the current design. Before that, can we keep the current implementation?

-    v8::V8::InitializeICU();
-    v8::Platform* platform = v8::platform::CreateDefaultPlatform();
-    v8::V8::InitializePlatform(platform);
-    v8::V8::Initialize();
 }
 static void FXJSE_Runtime_DisposeCallback(v8::Isolate* pIsolate)
 {
     {
         v8::Locker locker(pIsolate);
         CFXJSE_RuntimeData *pRuntimeData = reinterpret_cast<CFXJSE_RuntimeData*>(pIsolate->GetData(0));
         if(pRuntimeData) {
             pIsolate->SetData(0, NULL);
             delete pRuntimeData;
         }
@@ skipping 64 matching lines @@
 void CFXJSE_RuntimeList::RemoveAllRuntimes(CFXJSE_RuntimeList::RuntimeDisposeCallback lpfnDisposeCallback)
 {
     FX_INT32 iSize = m_RuntimeList.GetSize();
     if(lpfnDisposeCallback) {
         for(FX_INT32 iIdx = 0; iIdx < iSize; iIdx++) {
             lpfnDisposeCallback(m_RuntimeList[iIdx]);
         }
     }
     m_RuntimeList.RemoveAll();
 }