Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 887043002: Upstream utilities for iOS (Closed)

Created:
5 years, 10 months ago by droger
Modified:
5 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream utilities for iOS Committed: https://crrev.com/dc55754ca2189256e10b2ed33649b1ca5f335c38 Cr-Commit-Position: refs/heads/master@{#314326}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -4 lines) Patch
A ios/chrome/browser/arch_util.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/browser/arch_util.cc View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/chrome_url_constants.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/chrome/browser/chrome_url_constants.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ios/chrome/browser/translate/translate_service_ios_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 3 chunks +5 lines, -1 line 0 comments Download
A ios/chrome/test/ios_chrome_unit_test_suite.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/chrome/test/ios_chrome_unit_test_suite.cc View 1 1 chunk +67 lines, -0 lines 0 comments Download
A ios/chrome/test/run_all_unittests.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
droger
This is straight upstreaming with no changes
5 years, 10 months ago (2015-01-30 15:29:07 UTC) #2
sdefresne
https://codereview.chromium.org/887043002/diff/1/ios/chrome/test/ios_chrome_unit_test_suite.cc File ios/chrome/test/ios_chrome_unit_test_suite.cc (right): https://codereview.chromium.org/887043002/diff/1/ios/chrome/test/ios_chrome_unit_test_suite.cc#newcode20 ios/chrome/test/ios_chrome_unit_test_suite.cc:20: virtual ~IOSChromeUnitTestSuiteInitializer() {} ~IOSChromeUnitTestSuiteInitializer() {}
5 years, 10 months ago (2015-01-30 15:44:08 UTC) #3
droger
https://codereview.chromium.org/887043002/diff/1/ios/chrome/test/ios_chrome_unit_test_suite.cc File ios/chrome/test/ios_chrome_unit_test_suite.cc (right): https://codereview.chromium.org/887043002/diff/1/ios/chrome/test/ios_chrome_unit_test_suite.cc#newcode20 ios/chrome/test/ios_chrome_unit_test_suite.cc:20: virtual ~IOSChromeUnitTestSuiteInitializer() {} On 2015/01/30 15:44:08, sdefresne wrote: > ...
5 years, 10 months ago (2015-01-30 15:57:23 UTC) #4
droger
ping
5 years, 10 months ago (2015-02-03 13:35:42 UTC) #5
sdefresne
RS lgtm
5 years, 10 months ago (2015-02-03 13:40:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887043002/20001
5 years, 10 months ago (2015-02-03 13:42:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 13:45:56 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 13:47:08 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dc55754ca2189256e10b2ed33649b1ca5f335c38
Cr-Commit-Position: refs/heads/master@{#314326}

Powered by Google App Engine
This is Rietveld 408576698