ui/resources/PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/resources/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ui/events/PRESUBMIT.py ('k') | ui/resources/resource_check/resource_scale_factors.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for Chromium UI resources.	5 """Presubmit script for Chromium UI resources.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into gcl/git cl, and see	8 for more details about the presubmit API built into depot_tools, and see

9 http://www.chromium.org/developers/web-development-style-guide for the rules	9 http://www.chromium.org/developers/web-development-style-guide for the rules

10 we're checking against here.	10 we're checking against here.

11 """	11 """

12	12

13	13

14 def CheckChangeOnUpload(input_api, output_api):	14 def CheckChangeOnUpload(input_api, output_api):

15 return _CommonChecks(input_api, output_api)	15 return _CommonChecks(input_api, output_api)

16	16

17	17

18 def CheckChangeOnCommit(input_api, output_api):	18 def CheckChangeOnCommit(input_api, output_api):

(...skipping 18 matching lines...) Expand all Loading...
37 sys.path = [resources] + old_path	37 sys.path = [resources] + old_path

38 from resource_check import resource_scale_factors	38 from resource_check import resource_scale_factors

39	39

40 for paths in path_scales:	40 for paths in path_scales:

41 results.extend(resource_scale_factors.ResourceScaleFactors(	41 results.extend(resource_scale_factors.ResourceScaleFactors(

42 input_api, output_api, paths).RunChecks())	42 input_api, output_api, paths).RunChecks())

43 finally:	43 finally:

44 sys.path = old_path	44 sys.path = old_path

45	45

46 return results	46 return results

OLD	NEW