tools/metrics/histograms/PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/metrics/histograms/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/metrics/actions/PRESUBMIT.py ('k') | tools/perf/PRESUBMIT.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """	5 """

6 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	6 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

7 for more details on the presubmit API built into gcl.	7 for more details on the presubmit API built into depot_tools.

8 """	8 """

9	9

10	10

11 def CheckChange(input_api, output_api):	11 def CheckChange(input_api, output_api):

12 """Checks that histograms.xml is pretty-printed and well-formatted."""	12 """Checks that histograms.xml is pretty-printed and well-formatted."""

13 for f in input_api.AffectedTextFiles():	13 for f in input_api.AffectedTextFiles():

14 p = f.AbsoluteLocalPath()	14 p = f.AbsoluteLocalPath()

15 if (input_api.basename(p) == 'histograms.xml'	15 if (input_api.basename(p) == 'histograms.xml'

16 and input_api.os_path.dirname(p) == input_api.PresubmitLocalPath()):	16 and input_api.os_path.dirname(p) == input_api.PresubmitLocalPath()):

17 cwd = input_api.os_path.dirname(p)	17 cwd = input_api.os_path.dirname(p)

(...skipping 12 matching lines...) Expand all Loading...
30 'and fix the reported errors')]	30 'and fix the reported errors')]

31 return []	31 return []

32	32

33	33

34 def CheckChangeOnUpload(input_api, output_api):	34 def CheckChangeOnUpload(input_api, output_api):

35 return CheckChange(input_api, output_api)	35 return CheckChange(input_api, output_api)

36	36

37	37

38 def CheckChangeOnCommit(input_api, output_api):	38 def CheckChangeOnCommit(input_api, output_api):

39 return CheckChange(input_api, output_api)	39 return CheckChange(input_api, output_api)

OLD	NEW