Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: tools/cygprofile/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/crx_id/PRESUBMIT.py ('k') | tools/deep_memory_profiler/PRESUBMIT.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for cygprofile. 5 """Top-level presubmit script for cygprofile.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 details on the presubmit API built into gcl. 8 for more details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 11
12 def CommonChecks(input_api, output_api): 12 def CommonChecks(input_api, output_api):
13 output = [] 13 output = []
14 blacklist = [] 14 blacklist = []
15 output.extend(input_api.canned_checks.RunPylint( 15 output.extend(input_api.canned_checks.RunPylint(
16 input_api, output_api, black_list=blacklist)) 16 input_api, output_api, black_list=blacklist))
17 output.extend(input_api.canned_checks.RunUnitTests( 17 output.extend(input_api.canned_checks.RunUnitTests(
18 input_api, 18 input_api,
19 output_api, 19 output_api,
20 [input_api.os_path.join(input_api.PresubmitLocalPath(), 'run_tests')])) 20 [input_api.os_path.join(input_api.PresubmitLocalPath(), 'run_tests')]))
21 21
22 if input_api.is_committing: 22 if input_api.is_committing:
23 output.extend(input_api.canned_checks.PanProjectChecks(input_api, 23 output.extend(input_api.canned_checks.PanProjectChecks(input_api,
24 output_api, 24 output_api,
25 owners_check=False)) 25 owners_check=False))
26 return output 26 return output
27 27
28 28
29 def CheckChangeOnUpload(input_api, output_api): 29 def CheckChangeOnUpload(input_api, output_api):
30 return CommonChecks(input_api, output_api) 30 return CommonChecks(input_api, output_api)
31 31
32 32
33 def CheckChangeOnCommit(input_api, output_api): 33 def CheckChangeOnCommit(input_api, output_api):
34 return CommonChecks(input_api, output_api) 34 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « tools/crx_id/PRESUBMIT.py ('k') | tools/deep_memory_profiler/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698