tools/checkperms/PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/checkperms/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/binary_size/PRESUBMIT.py ('k') | tools/crx_id/PRESUBMIT.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Top-level presubmit script for checkperms.	5 """Top-level presubmit script for checkperms.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 details on the presubmit API built into gcl.	8 for more details on the presubmit API built into depot_tools.

9 """	9 """

10	10

11	11

12 def CommonChecks(input_api, output_api):	12 def CommonChecks(input_api, output_api):

13 output = []	13 output = []

14 output.extend(input_api.canned_checks.RunPylint(input_api, output_api))	14 output.extend(input_api.canned_checks.RunPylint(input_api, output_api))

15 # Run it like if it were a unit test.	15 # Run it like if it were a unit test.

16 output.extend(	16 output.extend(

17 input_api.canned_checks.RunUnitTests(	17 input_api.canned_checks.RunUnitTests(

18 input_api, output_api, ['./checkperms.py']))	18 input_api, output_api, ['./checkperms.py']))

19 return output	19 return output

20	20

21	21

22 def CheckChangeOnUpload(input_api, output_api):	22 def CheckChangeOnUpload(input_api, output_api):

23 return CommonChecks(input_api, output_api)	23 return CommonChecks(input_api, output_api)

24	24

25	25

26 def CheckChangeOnCommit(input_api, output_api):	26 def CheckChangeOnCommit(input_api, output_api):

27 return CommonChecks(input_api, output_api)	27 return CommonChecks(input_api, output_api)

OLD	NEW