Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Side by Side Diff: tools/binary_size/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/polymer/PRESUBMIT.py ('k') | tools/checkperms/PRESUBMIT.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """binary_size presubmit script 5 """binary_size presubmit script
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 def CommonChecks(input_api, output_api): 11 def CommonChecks(input_api, output_api):
12 output = [] 12 output = []
13 output.extend(input_api.canned_checks.RunPylint(input_api, output_api)) 13 output.extend(input_api.canned_checks.RunPylint(input_api, output_api))
14 output.extend( 14 output.extend(
15 input_api.canned_checks.RunUnitTestsInDirectory( 15 input_api.canned_checks.RunUnitTestsInDirectory(
16 input_api, output_api, 16 input_api, output_api,
17 input_api.PresubmitLocalPath(), 17 input_api.PresubmitLocalPath(),
18 whitelist=[r'.+_unittest\.py$'])) 18 whitelist=[r'.+_unittest\.py$']))
19 19
20 if input_api.is_committing: 20 if input_api.is_committing:
21 output.extend(input_api.canned_checks.PanProjectChecks(input_api, 21 output.extend(input_api.canned_checks.PanProjectChecks(input_api,
22 output_api, 22 output_api,
23 owners_check=False)) 23 owners_check=False))
24 return output 24 return output
25 25
26 26
27 def CheckChangeOnUpload(input_api, output_api): 27 def CheckChangeOnUpload(input_api, output_api):
28 return CommonChecks(input_api, output_api) 28 return CommonChecks(input_api, output_api)
29 29
30 30
31 def CheckChangeOnCommit(input_api, output_api): 31 def CheckChangeOnCommit(input_api, output_api):
32 return CommonChecks(input_api, output_api) 32 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « third_party/polymer/PRESUBMIT.py ('k') | tools/checkperms/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698