third_party/polymer/PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/polymer/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « testing/PRESUBMIT.py ('k') | tools/binary_size/PRESUBMIT.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Chromium presubmit script for third_party/polymer.	5 """Chromium presubmit script for third_party/polymer.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details on the presubmit API built into gcl.	8 for more details on the presubmit API built into depot_tools.

9 """	9 """

10	10

11 import os	11 import os

12 import json	12 import json

13	13

14 def _CheckBowerDependencies(input_api, output_api):	14 def _CheckBowerDependencies(input_api, output_api):

15 os_path = input_api.os_path	15 os_path = input_api.os_path

16 cwd = input_api.PresubmitLocalPath()	16 cwd = input_api.PresubmitLocalPath()

17 components_dir = os_path.join(cwd, 'components')	17 components_dir = os_path.join(cwd, 'components')

18 bower_json_path = os_path.join(cwd, 'bower.json')	18 bower_json_path = os_path.join(cwd, 'bower.json')

(...skipping 25 matching lines...) Expand all Loading...
44 items = list(bower_dependencies - installed_components)))	44 items = list(bower_dependencies - installed_components)))

45	45

46 return problems	46 return problems

47	47

48 def CheckChangeOnUpload(input_api, output_api):	48 def CheckChangeOnUpload(input_api, output_api):

49 return _CheckBowerDependencies(input_api, output_api)	49 return _CheckBowerDependencies(input_api, output_api)

50	50

51	51

52 def CheckChangeOnCommit(input_api, output_api):	52 def CheckChangeOnCommit(input_api, output_api):

53 return _CheckBowerDependencies(input_api, output_api)	53 return _CheckBowerDependencies(input_api, output_api)

OLD	NEW