OLD | NEW |
1 # Copyright 2014 The Chromium Authors. All rights reserved. | 1 # Copyright 2014 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Chromium presubmit script for src/extensions/browser. | 5 """Chromium presubmit script for src/extensions/browser. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details on the presubmit API built into gcl. | 8 for more details on the presubmit API built into depot_tools. |
9 """ | 9 """ |
10 | 10 |
11 import sys | 11 import sys |
12 | 12 |
13 def _CreateHistogramValueChecker(input_api, output_api): | 13 def _CreateHistogramValueChecker(input_api, output_api): |
14 original_sys_path = sys.path | 14 original_sys_path = sys.path |
15 | 15 |
16 try: | 16 try: |
17 sys.path.append(input_api.os_path.join( | 17 sys.path.append(input_api.os_path.join( |
18 input_api.PresubmitLocalPath(), '..', '..', 'tools', | 18 input_api.PresubmitLocalPath(), '..', '..', 'tools', |
19 'strict_enum_value_checker')) | 19 'strict_enum_value_checker')) |
20 from strict_enum_value_checker import StrictEnumValueChecker | 20 from strict_enum_value_checker import StrictEnumValueChecker |
21 finally: | 21 finally: |
22 sys.path = original_sys_path | 22 sys.path = original_sys_path |
23 | 23 |
24 return StrictEnumValueChecker(input_api, output_api, | 24 return StrictEnumValueChecker(input_api, output_api, |
25 start_marker='enum HistogramValue {', end_marker=' // Last entry:', | 25 start_marker='enum HistogramValue {', end_marker=' // Last entry:', |
26 path='extensions/browser/extension_function_histogram_value.h') | 26 path='extensions/browser/extension_function_histogram_value.h') |
27 | 27 |
28 def CheckChangeOnUpload(input_api, output_api): | 28 def CheckChangeOnUpload(input_api, output_api): |
29 results = [] | 29 results = [] |
30 results += _CreateHistogramValueChecker(input_api, output_api).Run() | 30 results += _CreateHistogramValueChecker(input_api, output_api).Run() |
31 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) | 31 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) |
32 return results | 32 return results |
33 | 33 |
34 def CheckChangeOnCommit(input_api, output_api): | 34 def CheckChangeOnCommit(input_api, output_api): |
35 return _CreateHistogramValueChecker(input_api, output_api).Run() | 35 return _CreateHistogramValueChecker(input_api, output_api).Run() |
OLD | NEW |