content/test/PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/activity_log_private/PRESUBMIT.py ('k') | extensions/browser/PRESUBMIT.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """test_expectations.txt presubmit script.	5 """test_expectations.txt presubmit script.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 details on the presubmit API built into gcl.	8 for more details on the presubmit API built into depot_tools.

9 """	9 """

10	10

11 import os	11 import os

12 import sys	12 import sys

13	13

14 TEST_EXPECTATIONS_FILENAMES = ['test_expectations.txt', 'TestExpectations']	14 TEST_EXPECTATIONS_FILENAMES = ['test_expectations.txt', 'TestExpectations']

15	15

16 def LintTestFiles(input_api, output_api):	16 def LintTestFiles(input_api, output_api):

17 current_dir = str(input_api.PresubmitLocalPath())	17 current_dir = str(input_api.PresubmitLocalPath())

18 tools_dir = os.path.dirname(os.path.abspath(sys.argv[0]))	18 tools_dir = os.path.dirname(os.path.abspath(sys.argv[0]))

(...skipping 20 matching lines...) Expand all Loading...
39 if input_api.os_path.basename(path) in TEST_EXPECTATIONS_FILENAMES:	39 if input_api.os_path.basename(path) in TEST_EXPECTATIONS_FILENAMES:

40 return LintTestFiles(input_api, output_api)	40 return LintTestFiles(input_api, output_api)

41 return []	41 return []

42	42

43	43

44 def CheckChangeOnUpload(input_api, output_api):	44 def CheckChangeOnUpload(input_api, output_api):

45 return LintTestExpectations(input_api, output_api)	45 return LintTestExpectations(input_api, output_api)

46	46

47 def CheckChangeOnCommit(input_api, output_api):	47 def CheckChangeOnCommit(input_api, output_api):

48 return LintTestExpectations(input_api, output_api)	48 return LintTestExpectations(input_api, output_api)

OLD	NEW